Add RegConnectRegistry to Advapi32 mappings (#935)

Author: cxcorp

CHANGES.md

@@ -14,6 +14,7 @@ Features
 * [#913](https://github.com/java-native-access/jna/issues/913): Add `@ComInterface` annotation to `com.sun.jna.platform.win32.COM.util.IConnectionPoint` to make it possible to retrieve it via `IUnknown#queryInterface` - [@matthiasblaesing](https://github.com/matthiasblaesing).
 * [#797](https://github.com/java-native-access/jna/issues/797): Binding `Advapi32#EnumDependendServices`, `Advapi32#EnumServicesStatusEx` and `Advapi32#QueryServiceStatus`. `W32Service#stopService` was modified to be more resilent when stopping service - [@matthiasblaesing](https://github.com/matthiasblaesing).
 * Bind `com.sun.jna.platform.win32.Kernel32.ExpandEnvironmentStrings` and add helper method for it as `Kernel32Util#expandEnvironmentStrings` - [@matthiasblaesing](https://github.com/matthiasblaesing).
+* [#935](https://github.com/java-native-access/jna/pull/935): Add RegConnectRegistry to Advapi32 mappings. - [@cxcorp](https://github.com/cxcorp).
 
 Bug Fixes
 ---------

contrib/platform/src/com/sun/jna/platform/win32/Advapi32.java

@@ -854,6 +854,46 @@ boolean GetTokenInformation(HANDLE tokenHandle,
     int RegOpenKeyEx(HKEY hKey, String lpSubKey, int ulOptions,
                      int samDesired, HKEYByReference phkResult);
 
+    /**
+     * Establishes a connection to a predefined registry key on another
+     * computer.
+     * @param lpMachineName
+     *            The name of the remote computer. The string has
+     *            the following form:<br />
+     *            <pre><code>\\computername</code></pre>
+     *            The caller must have access to the remote computer or the
+     *            function fails.<br />
+     *            If this parameter is <c>null</c>, the local computer name
+     *            is used.
+     * @param hKey
+     *            A predefined registry handle. This parameter can be one of
+     *            the following predefined keys on the remote computer.<br />
+     *            <ul>
+     *                <li>{@link WinReg#HKEY_LOCAL_MACHINE}</li>
+     *                <li>{@link WinReg#HKEY_PERFORMANCE_DATA}</li>
+     *                <li>{@link WinReg#HKEY_USERS}</li>
+     *            </ul>
+     * @param phkResult
+     *            A pointer to a variable that receives a key handle
+     *            identifying the predefined handle on the remote computer.
+     * @return If the function succeeds, the return value is
+     *         {@link WinError#ERROR_SUCCESS}.<br />
+     *         If the remote computer cannot be found or if its Remote Registry
+     *         service is disabled, the function fails and returns 
+     *         {@link WinError#ERROR_BAD_NETPATH}.<br />
+     *         If attempting to use a registry handle other than one of the
+     *         three predefined handles, the function fails and returns
+     *         {@link WinError#ERROR_INVALID_HANDLE}.<br />
+     *         If access to the registry is denied, the function fails and
+     *         returns {@link WinError#ERROR_ACCESS_DENIED}. <br />
+     *         If the function fails for some other reason, you can use the
+     *         {@link Native#getLastError} method to get a generic description
+     *         of the error.
+     * @see <a href="https://msdn.microsoft.com/en-us/library/windows/desktop/ms724840.aspx">RegConnectRegistry function (Windows)</a>
+     * @see <a href="https://msdn.microsoft.com/en-us/library/windows/desktop/ms724836.aspx">Predefined Keys (Windows)</a>
+     */
+    int RegConnectRegistry(String lpMachineName, HKEY hKey, HKEYByReference phkResult);
+
     /**
      * The RegQueryValueEx function retrieves the type and data for a specified
      * value name associated with an open registry key.

contrib/platform/test/com/sun/jna/platform/win32/Advapi32Test.java

@@ -493,6 +493,26 @@ public void testRegOpenKeyEx() {
     	assertEquals(W32Errors.ERROR_SUCCESS, Advapi32.INSTANCE.RegCloseKey(phKey.getValue()));
     }
 
+    public void testRegConnectRegistry() {
+    	HKEYByReference phkResult = new HKEYByReference();
+    	int connectResult = Advapi32.INSTANCE.RegConnectRegistry(
+    			"\\\\localhost", WinReg.HKEY_LOCAL_MACHINE, phkResult);
+    
+    	if (connectResult == W32Errors.ERROR_BAD_NETPATH) {
+    		System.err.println("Failed to connect to registry with RegConnectRegistry, remote registry service is probably disabled");
+    		return;
+    	}
+    
+    	if (connectResult == W32Errors.ERROR_ACCESS_DENIED) {
+    		System.err.println("Access was denied when connecting to registry with RegConnectRegistry");
+    		return;
+    	}
+    
+    	assertEquals(W32Errors.ERROR_SUCCESS, connectResult);
+    	assertTrue(WinBase.INVALID_HANDLE_VALUE != phkResult.getValue());
+    	assertEquals(W32Errors.ERROR_SUCCESS, Advapi32.INSTANCE.RegCloseKey(phkResult.getValue()));
+    }
+
     public void testRegQueryValueEx() {
     	HKEYByReference phKey = new HKEYByReference();
     	assertEquals(W32Errors.ERROR_SUCCESS, Advapi32.INSTANCE.RegOpenKeyEx(