Fix free_callback JNI weak reference leak

xiezhaokun · xiezhaokun · commit 9e9287c92841 · 2024-01-09T10:45:47.000+08:00
diff --git a/native/callback.c b/native/callback.c
@@ -328,7 +328,7 @@ free_callback(JNIEnv* env, callback *cb) {
   free(cb->arg_types);
   if (cb->arg_classes) {
     unsigned i;
-    for (i=0;i < cb->cif.nargs;i++) {
+    for (i=0;i < cb->arg_classes;i++) {
       if (cb->arg_classes[i]) {
         (*env)->DeleteWeakGlobalRef(env, cb->arg_classes[i]);
       }

Original file line number	Diff line number	Diff line change
`@@ -328,7 +328,7 @@ free_callback(JNIEnv* env, callback *cb) {`
`328`	`328`	`free(cb->arg_types);`
`329`	`329`	`if (cb->arg_classes) {`
`330`	`330`	`unsigned i;`
`331`		`- for (i=0;i < cb->cif.nargs;i++) {`
	`331`	`+ for (i=0;i < cb->arg_classes;i++) {`
`332`	`332`	`if (cb->arg_classes[i]) {`
`333`	`333`	`(*env)->DeleteWeakGlobalRef(env, cb->arg_classes[i]);`
`334`	`334`	`}`