Skip to content
This repository was archived by the owner on Feb 12, 2024. It is now read-only.

Enable Bitswap tests on Windows #1313

Closed
vmx opened this issue Apr 17, 2018 · 4 comments · Fixed by #1483
Closed

Enable Bitswap tests on Windows #1313

vmx opened this issue Apr 17, 2018 · 4 comments · Fixed by #1483
Assignees
@alanshaw
Labels
exp/expert Having worked on the specific codebase is important

Comments

@vmx
Copy link
Member

vmx commented Apr 17, 2018

The Bitswap test file says that enabling the tests is blocked by ipfs/js-ipfsd-ctl#205 which got merged. So it seems that the Bitswap tests could be enabled on Windows.
@vmx vmx added the exp/expert Having worked on the specific codebase is important label Apr 17, 2018
@dryajov
Copy link
Member

dryajov commented Apr 19, 2018

Yes, it should be possible to enable it now.

@daviddias daviddias added exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue status/ready Ready to be worked env:Windows exp/expert Having worked on the specific codebase is important and removed exp/expert Having worked on the specific codebase is important exp/novice Someone with a little familiarity can pick up env:Windows help wanted Seeking public contribution on this issue labels May 30, 2018
alanshaw added a commit that referenced this issue May 30, 2018
@alanshaw
chore: enable bitswap tests on windows
a95a729 
resolves #1313

License: MIT
Signed-off-by: Alan Shaw <alan@tableflip.io>
@alanshaw
Copy link
Member

Still not working unfortunately:

  1) bitswap "after each" hook:

     Uncaught Error: EBUSY: resource busy or locked, unlink 'C:\Windows\TEMP\ipfs-test-cb6c22963a56dc17c6cbeb51cb7936e2\datastore\LOG'

      at Object.fs.unlinkSync (fs.js:1081:18)

      at rimrafSync (node_modules\rimraf\rimraf.js:306:17)

      at node_modules\rimraf\rimraf.js:342:5

      at Array.forEach (<anonymous>)

      at rmkidsSync (node_modules\rimraf\rimraf.js:341:26)

      at rmdirSync (node_modules\rimraf\rimraf.js:334:7)

      at rimrafSync (node_modules\rimraf\rimraf.js:304:9)

      at node_modules\rimraf\rimraf.js:342:5

      at Array.forEach (<anonymous>)

      at rmkidsSync (node_modules\rimraf\rimraf.js:341:26)

      at rmdirSync (node_modules\rimraf\rimraf.js:334:7)

      at Function.rimrafSync [as sync] (node_modules\rimraf\rimraf.js:304:9)

      at Object.removeRepo (node_modules\ipfsd-ctl\src\utils\repo\nodejs.js:17:17)

      at Node.cleanup (node_modules\ipfsd-ctl\src\ipfsd-in-proc.js:181:15)

      at exec.stop (node_modules\ipfsd-ctl\src\ipfsd-in-proc.js:241:21)

      at done (src\core\components\stop.js:27:7)

      at node_modules\async\internal\parallel.js:39:9

      at node_modules\async\internal\once.js:12:16

      at replenish (node_modules\async\internal\eachOfLimit.js:61:25)

      at iterateeCallback (node_modules\async\internal\eachOfLimit.js:50:17)

      at node_modules\async\internal\onlyOnce.js:12:16

      at node_modules\async\internal\parallel.js:36:13

      at series (node_modules\ipfs-repo\src\index.js:257:17)

      at node_modules\async\internal\parallel.js:39:9

      at node_modules\async\internal\once.js:12:16

      at replenish (node_modules\async\internal\eachOfLimit.js:61:25)

      at iterateeCallback (node_modules\async\internal\eachOfLimit.js:50:17)

      at node_modules\async\internal\onlyOnce.js:12:16

      at node_modules\async\internal\parallel.js:36:13

      at node_modules\async\internal\parallel.js:39:9

      at node_modules\async\internal\once.js:12:16

      at replenish (node_modules\async\internal\eachOfLimit.js:61:25)

      at iterateeCallback (node_modules\async\internal\eachOfLimit.js:50:17)

      at node_modules\async\internal\onlyOnce.js:12:16

      at node_modules\async\internal\parallel.js:36:13

      at FSReqWrap.oncomplete (fs.js:149:15)

@daviddias
Copy link
Member

daviddias commented Jul 5, 2018 •
edited
Loading

All good now?

alanshaw added a commit that referenced this issue Aug 2, 2018
@alanshaw
test: enable bitswap tests on windows
4add4ef 
closes #1313

License: MIT
Signed-off-by: Alan Shaw <alan@tableflip.io>
@alanshaw alanshaw mentioned this issue Aug 2, 2018
Merged
@ghost ghost assigned alanshaw Aug 2, 2018
@ghost ghost added status/in-progress In progress and removed status/ready Ready to be worked labels Aug 2, 2018
@alanshaw
Copy link
Member

alanshaw commented Aug 2, 2018

trying it again here #1483

alanshaw added a commit that referenced this issue Aug 6, 2018
@alanshaw
test: enable bitswap tests on windows
4018a71 
closes #1313

License: MIT
Signed-off-by: Alan Shaw <alan@tableflip.io>
alanshaw added a commit that referenced this issue Aug 7, 2018
@alanshaw
test: enable bitswap tests on windows
ec39268 
closes #1313

License: MIT
Signed-off-by: Alan Shaw <alan@tableflip.io>
@ghost ghost removed the status/in-progress In progress label Aug 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alanshaw alanshaw

Labels
exp/expert Having worked on the specific codebase is important
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: enable bitswap tests on windows ipfs/js-ipfs
4 participants
@vmx @alanshaw @dryajov @daviddias