Skip to content

Commit 20b608e

Browse files
chore: sync script deletes existing tgz packages (#27045)
<!-- Please refer to our contributing documentation for any questions on submitting a pull request, or let us know here if you need any help: https://ionicframework.com/docs/building/contributing --> ## Pull request checklist Please check if your PR fulfills the following requirements: - [ ] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been reviewed and added / updated if needed (for bug fixes / features) - Some docs updates need to be made in the `ionic-docs` repo, in a separate PR. See the [contributing guide](https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#modifying-documentation) for details. - [ ] Build (`npm run build`) was run locally and any changes were pushed - [ ] Lint (`npm run lint`) has passed locally and any fixes were made for failures ## Pull request type <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type, submit multiple pull requests if needed. --> Please check the type of change your PR introduces: - [ ] Bugfix - [ ] Feature - [ ] Code style update (formatting, renaming) - [ ] Refactoring (no functional changes, no api changes) - [x] Build related changes - [ ] Documentation content changes - [ ] Other (please describe): ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> When testing changes locally, you can have an existing test app that you sync the package contents to. If you have done this across different versions of Ionic, it can install the wrong .tgz file instead of the local changes. Experienced here: #27040 (review) <!-- Issues are required for both bug fixes and features. --> Issue URL: N/A ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Sync script deletes all .tgz files local to the directory before locally packing and installing the contents of the parent local packages ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> --------- Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
1 parent cefbd1a commit 20b608e

File tree

7 files changed

+21
-0
lines changed

7 files changed

+21
-0
lines changed

angular/scripts/sync.sh

+3
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22

33
set -e
44

5+
# Delete old packages
6+
rm -f *.tgz
7+
58
# Pack @ionic/core
69
npm pack ../core
710

angular/test/base/scripts/sync.sh

+3
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22

33
set -e
44

5+
# Delete old packages
6+
rm -f *.tgz
7+
58
# Pack @ionic/core
69
npm pack ../../../../core
710

packages/react-router/test/base/scripts/sync.sh

+3
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22

33
set -e
44

5+
# Delete old packages
6+
rm -f *.tgz
7+
58
# Pack @ionic/core
69
npm pack ../../../../../core
710

packages/react/test/base/scripts/sync.sh

+3
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22

33
set -e
44

5+
# Delete old packages
6+
rm -f *.tgz
7+
58
# Pack @ionic/core
69
npm pack ../../../../../core
710

packages/vue-router/scripts/sync.sh

+3
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22

33
set -e
44

5+
# Delete old packages
6+
rm -f *.tgz
7+
58
# Pack @ionic/core
69
npm pack ../../core
710

packages/vue/scripts/sync.sh

+3
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22

33
set -e
44

5+
# Delete old packages
6+
rm -f *.tgz
7+
58
# Pack @ionic/core
69
npm pack ../../core
710

packages/vue/test/base/scripts/sync.sh

+3
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22

33
set -e
44

5+
# Delete old packages
6+
rm -f *.tgz
7+
58
# Pack @ionic/core
69
npm pack ../../../../../core
710

0 commit comments

Comments
 (0)