(a) The system shall throw an error if the user specifies either kernel_coverage_check or material_coverage_check together with default_block. (b) The system shall allow users to include ANY_BLOCK_ID in the default_block parameter. (c) Avoiding unnecessary copying of the block_param vector by using a reference.

Author: ChengHauYang

framework/include/problems/FEProblemBase.h

@@ -2398,7 +2398,7 @@ class FEProblemBase : public SubProblem, public Restartable
   /**
    * @returns the default blocks (for block restriction)
    */
-  const std::vector<SubdomainName> getDefaultBlocks() const { return _default_blocks; };
+  const std::vector<SubdomainName> & getDefaultBlocks() const { return _default_blocks; };
 
 protected:
   /// Create extra tagged vectors and matrices

framework/src/interfaces/BlockRestrictable.C

@@ -121,10 +121,16 @@ BlockRestrictable::initializeBlockRestrictable(const MooseObject * moose_object)
   else if (_blk_feproblem->isParamSetByUser("default_block"))
   {
     _blocks = _blk_feproblem->getDefaultBlocks();
-    // Get the IDs from the supplied names
-    _vec_ids = _blk_mesh->getSubdomainIDs(_blocks);
 
-    _blk_ids.insert(_vec_ids.begin(), _vec_ids.end());
+    // Store the IDs in a set, handling ANY_BLOCK_ID if supplied
+    if (std::find(_blocks.begin(), _blocks.end(), "ANY_BLOCK_ID") != _blocks.end())
+      _blk_ids.insert(Moose::ANY_BLOCK_ID);
+    else
+    {
+      // Get the IDs from the supplied names
+      _vec_ids = _blk_mesh->getSubdomainIDs(_blocks);
+      _blk_ids.insert(_vec_ids.begin(), _vec_ids.end());
+    }
   }
 
   // Produce error if the object is not allowed to be both block and boundary restricted

framework/src/problems/FEProblemBase.C

@@ -514,6 +514,17 @@ FEProblemBase::FEProblemBase(const InputParameters & parameters)
     _identify_variable_groups_in_nl(getParam<bool>("identify_variable_groups_in_nl")),
     _regard_general_exceptions_as_errors(getParam<bool>("regard_general_exceptions_as_errors"))
 {
+
+  auto checkConflict = [this](const std::string & coverage_check)
+  {
+    if (isParamSetByUser(coverage_check) && isParamSetByUser("default_block"))
+      mooseError("Cannot set both '" + coverage_check +
+                 "' and 'default_block'. Please set only one.");
+  };
+
+  checkConflict("kernel_coverage_check");
+  checkConflict("material_coverage_check");
+
   //  Initialize static do_derivatives member. We initialize this to true so that all the default AD
   //  things that we setup early in the simulation actually get their derivative vectors initalized.
   //  We will toggle this to false when doing residual evaluations

framework/src/systems/SystemBase.C

@@ -719,11 +719,12 @@ SystemBase::addVariable(const std::string & var_type,
   // Convert the std::vector parameter provided by the user into a std::set for use by libMesh's
   // System::add_variable method
   std::set<SubdomainID> blocks;
-  auto block_param = parameters.get<std::vector<SubdomainName>>("block");
-  if (block_param.empty() && _fe_problem.isParamValid("default_block"))
-    block_param = _fe_problem.getDefaultBlocks();
+  const std::vector<SubdomainName> * block_param =
+      &parameters.get<std::vector<SubdomainName>>("block");
+  if (block_param->empty() && _fe_problem.isParamValid("default_block"))
+    block_param = &_fe_problem.getDefaultBlocks();
 
-  for (const auto & subdomain_name : block_param)
+  for (const auto & subdomain_name : *block_param)
   {
     SubdomainID blk_id = _mesh.getSubdomainID(subdomain_name);
     blocks.insert(blk_id);

test/tests/default_block_check/gold/diffusion_with_null_material_kernel_coverage_override_out.e

@@ -15,11 +15,14 @@
       exodiff = 'diffusion_with_null_material_different_kernel_differnt_blocks_out.e'
       detail = 'Check whether different kernels can be assigned to different blocks, as long as the block IDs belong to the default_block list.'
     []
-    [kernel_coverage_override]
-      type = 'Exodiff'
+  []
+  [error_test]
+    requirement = 'The system shall throw an error if the user sets either kernel_coverage_check or material_coverage_check together with default_block'
+    [error]
+      type = RunException
       input = 'diffusion_with_null_material_kernel_coverage_override.i'
-      exodiff = 'diffusion_with_null_material_kernel_coverage_override_out.e'
-      detail = 'Check whether kernel coverage override is allowed even when default_block is specified.'
+      expect_err = "Cannot set both 'kernel_coverage_check' and 'default_block'. Please set only one."
+      detail = 'Ensure that an error is thrown when user set both kernel_coverage_check and default_block in the [Problem].'
     []
   []
 []