PR #605: Suppress CA1707 warnings in the Constants classes

Numpsy · web-flow · commit 1493f69a3328 · 2021-04-27T21:12:36.000+02:00
diff --git a/src/ICSharpCode.SharpZipLib/GZip/GZipConstants.cs b/src/ICSharpCode.SharpZipLib/GZip/GZipConstants.cs
@@ -3,6 +3,7 @@ namespace ICSharpCode.SharpZipLib.GZip
 	/// <summary>
 	/// This class contains constants used for gzip.
 	/// </summary>
+	[System.Diagnostics.CodeAnalysis.SuppressMessage("Naming", "CA1707:Identifiers should not contain underscores", Justification = "kept for backwards compatibility")]
 	sealed public class GZipConstants
 	{
 		/// <summary>
diff --git a/src/ICSharpCode.SharpZipLib/Zip/Compression/DeflaterConstants.cs b/src/ICSharpCode.SharpZipLib/Zip/Compression/DeflaterConstants.cs
@@ -5,6 +5,7 @@ namespace ICSharpCode.SharpZipLib.Zip.Compression
 	/// <summary>
 	/// This class contains constants used for deflation.
 	/// </summary>
+	[System.Diagnostics.CodeAnalysis.SuppressMessage("Naming", "CA1707:Identifiers should not contain underscores", Justification = "kept for backwards compatibility")]
 	public static class DeflaterConstants
 	{
 		/// <summary>
diff --git a/src/ICSharpCode.SharpZipLib/Zip/ZipConstants.cs b/src/ICSharpCode.SharpZipLib/Zip/ZipConstants.cs
@@ -237,6 +237,7 @@ public enum GeneralBitFlags
 	/// <summary>
 	/// This class contains constants used for Zip format files
 	/// </summary>
+	[System.Diagnostics.CodeAnalysis.SuppressMessage("Naming", "CA1707:Identifiers should not contain underscores", Justification = "kept for backwards compatibility")]
 	public static class ZipConstants
 	{
 		#region Versions

Original file line number	Diff line number	Diff line change
`@@ -3,6 +3,7 @@ namespace ICSharpCode.SharpZipLib.GZip`
`3`	`3`	`/// <summary>`
`4`	`4`	`/// This class contains constants used for gzip.`
`5`	`5`	`/// </summary>`
	`6`	`+ [System.Diagnostics.CodeAnalysis.SuppressMessage("Naming", "CA1707:Identifiers should not contain underscores", Justification = "kept for backwards compatibility")]`
`6`	`7`	`sealed public class GZipConstants`
`7`	`8`	`{`
`8`	`9`	`/// <summary>`
Original file line number	Diff line number	Diff line change
`@@ -5,6 +5,7 @@ namespace ICSharpCode.SharpZipLib.Zip.Compression`
`5`	`5`	`/// <summary>`
`6`	`6`	`/// This class contains constants used for deflation.`
`7`	`7`	`/// </summary>`
	`8`	`+ [System.Diagnostics.CodeAnalysis.SuppressMessage("Naming", "CA1707:Identifiers should not contain underscores", Justification = "kept for backwards compatibility")]`
`8`	`9`	`public static class DeflaterConstants`
`9`	`10`	`{`
`10`	`11`	`/// <summary>`
Original file line number	Diff line number	Diff line change
`@@ -237,6 +237,7 @@ public enum GeneralBitFlags`
`237`	`237`	`/// <summary>`
`238`	`238`	`/// This class contains constants used for Zip format files`
`239`	`239`	`/// </summary>`
	`240`	`+ [System.Diagnostics.CodeAnalysis.SuppressMessage("Naming", "CA1707:Identifiers should not contain underscores", Justification = "kept for backwards compatibility")]`
`240`	`241`	`public static class ZipConstants`
`241`	`242`	`{`
`242`	`243`	`#region Versions`