Skip to content

Make Pattern Library put extra routes in default group if group is not set #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lyzadanger opened this issue Sep 7, 2021 · 1 comment
Labels
pattern library concerning the build, structure, styling or components for the pattern library

Comments

@lyzadanger
Copy link
Contributor

lyzadanger commented Sep 7, 2021

Per this PR: hypothesis/client#3738

This manifested as a type-linting problem, but I think it overlays an ergonomic one.

It's a bit of a pain for authors to have to provide a group, and that that group needs to conform to a somewhat arbitrary set of groups. A couple of possibilities:

  • Make group optional (or even disallowed) for "extra" routes provided by external applications. By default, put these routes into a group that is defined by the pattern library (not externally).
  • Perhaps stop restricting group names for external applications (i.e. allow external applications to use whatever "groups" they want).
@lyzadanger lyzadanger added the pattern library concerning the build, structure, styling or components for the pattern library label Sep 7, 2021
@lyzadanger
Copy link
Contributor Author

Now part of #450

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pattern library concerning the build, structure, styling or components for the pattern library
Projects
None yet
Development

No branches or pull requests

1 participant