File tree 14 files changed +37
-67
lines changed
instrumentation/servlet/servlet-3.0-no-wrapping/src
main/java/io/opentelemetry/javaagent/instrumentation/hypertrace/servlet/v3_0/nowrapping
io/opentelemetry/javaagent/instrumentation/hypertrace/servlet/v3_0/nowrapping
src/test/groovy/org/hypertrace/agent/smoketest
14 files changed +37
-67
lines changed Original file line number Diff line number Diff line change @@ -29,11 +29,11 @@ subprojects {
29
29
description = " Hypertrace OpenTelemetry Javaagent"
30
30
31
31
extra.set(" versions" , mapOf (
32
- " opentelemetry" to " 0.17.1 " ,
33
- " opentelemetry_java_agent" to " 0.17 .0-alpha" ,
34
- " opentelemetry_java_agent_all" to " 0.17 .0" ,
35
- " byte_buddy" to " 1.10.18" ,
36
- " slf4j" to " 1.7.30"
32
+ " opentelemetry" to " 1.0.0 " ,
33
+ " opentelemetry_java_agent" to " 1.0 .0-alpha" ,
34
+ " opentelemetry_java_agent_all" to " 1.0 .0" ,
35
+ " byte_buddy" to " 1.10.18" ,
36
+ " slf4j" to " 1.7.30"
37
37
))
38
38
39
39
apply<JavaPlugin >()
Original file line number Diff line number Diff line change 16
16
17
17
package io .opentelemetry .javaagent .instrumentation .hypertrace .servlet .v3_0 .nowrapping ;
18
18
19
- import static io .opentelemetry .javaagent .tooling .bytebuddy .matcher .ClassLoaderMatcher .hasClassesNamed ;
20
-
21
19
import com .google .auto .service .AutoService ;
22
20
import io .opentelemetry .javaagent .instrumentation .hypertrace .servlet .v3_0 .nowrapping .request .ServletInputStreamInstrumentation ;
23
21
import io .opentelemetry .javaagent .instrumentation .hypertrace .servlet .v3_0 .nowrapping .request .ServletRequestInstrumentation ;
29
27
import java .util .HashMap ;
30
28
import java .util .List ;
31
29
import java .util .Map ;
32
- import net .bytebuddy .matcher .ElementMatcher ;
33
30
import org .hypertrace .agent .core .instrumentation .SpanAndObjectPair ;
34
31
import org .hypertrace .agent .core .instrumentation .buffer .BoundedByteArrayOutputStream ;
35
32
import org .hypertrace .agent .core .instrumentation .buffer .BoundedCharArrayWriter ;
@@ -48,11 +45,6 @@ public int getOrder() {
48
45
return 1 ;
49
46
}
50
47
51
- @ Override
52
- public ElementMatcher .Junction <ClassLoader > classLoaderMatcher () {
53
- return hasClassesNamed ("javax.servlet.http.HttpServlet" );
54
- }
55
-
56
48
@ Override
57
49
public List <TypeInstrumentation > typeInstrumentations () {
58
50
return Arrays .asList (
Original file line number Diff line number Diff line change 35
35
import okhttp3 .Request ;
36
36
import okhttp3 .RequestBody ;
37
37
import okhttp3 .Response ;
38
+ import org .WrappingFilter ;
38
39
import org .eclipse .jetty .server .Server ;
39
40
import org .eclipse .jetty .servlet .ServletContextHandler ;
40
41
import org .hypertrace .agent .core .instrumentation .HypertraceSemanticAttributes ;
Original file line number Diff line number Diff line change 14
14
* limitations under the License.
15
15
*/
16
16
17
- package io . opentelemetry . javaagent . instrumentation . hypertrace . servlet . v3_0 . nowrapping ;
17
+ package org ;
18
18
19
19
import java .io .BufferedReader ;
20
20
import java .io .IOException ;
31
31
import javax .servlet .http .HttpServletRequestWrapper ;
32
32
import javax .servlet .http .HttpServletResponse ;
33
33
import javax .servlet .http .HttpServletResponseWrapper ;
34
- import org .DelegatingBufferedReader ;
35
- import org .DelegatingPrintWriter ;
36
- import org .DelegatingServletInputStream ;
37
- import org .DelegatingServletOutputStream ;
38
34
39
35
public class WrappingFilter implements Filter {
40
36
Original file line number Diff line number Diff line change @@ -9,6 +9,7 @@ dependencies {
9
9
10
10
compileOnly(" io.opentelemetry:opentelemetry-sdk:${versions[" opentelemetry" ]} " )
11
11
compileOnly(" io.opentelemetry:opentelemetry-sdk-extension-autoconfigure:${versions[" opentelemetry" ]} -alpha" )
12
+ implementation(" io.opentelemetry:opentelemetry-semconv:${versions[" opentelemetry" ]} -alpha" )
12
13
implementation(" io.opentelemetry.javaagent:opentelemetry-javaagent-spi:${versions[" opentelemetry_java_agent" ]} " )
13
14
14
15
implementation(" org.slf4j:slf4j-api:${versions[" slf4j" ]} " )
Original file line number Diff line number Diff line change @@ -15,13 +15,14 @@ dependencies{
15
15
testImplementation(" org.testcontainers:testcontainers:1.15.2" )
16
16
testImplementation(" com.squareup.okhttp3:okhttp:4.9.0" )
17
17
testImplementation(" org.awaitility:awaitility:4.0.3" )
18
- testImplementation(" io.opentelemetry:opentelemetry-proto:${versions[" opentelemetry" ]} " )
18
+ testImplementation(" io.opentelemetry:opentelemetry-proto:${versions[" opentelemetry" ]} -alpha " )
19
19
testImplementation(" io.opentelemetry:opentelemetry-sdk:${versions[" opentelemetry" ]} " )
20
20
testImplementation(" com.google.protobuf:protobuf-java-util:3.13.0" )
21
21
testImplementation(" org.spockframework:spock-core:1.3-groovy-2.5" )
22
22
testImplementation(" info.solidsoft.spock:spock-global-unroll:0.5.1" )
23
23
testImplementation(" com.fasterxml.jackson.core:jackson-databind:2.11.2" )
24
24
testImplementation(" org.codehaus.groovy:groovy-all:2.5.11" )
25
+ testImplementation(" io.opentelemetry:opentelemetry-semconv:${versions[" opentelemetry" ]} -alpha" )
25
26
}
26
27
27
28
tasks.test {
Original file line number Diff line number Diff line change @@ -364,7 +364,19 @@ abstract class AppServerTest extends SmokeTest {
364
364
[appServer, jdk] << getTestParams()
365
365
}
366
366
367
- protected abstract String getSpanName (String path );
367
+ protected String getSpanName (String path ) {
368
+ switch (path) {
369
+ case " /app/greeting" :
370
+ case " /app/headers" :
371
+ case " /app/exception" :
372
+ case " /app/asyncgreeting" :
373
+ return path
374
+ case " /app/hello.txt" :
375
+ case " /app/file-that-does-not-exist" :
376
+ return " /app/*"
377
+ }
378
+ return " HTTP GET"
379
+ }
368
380
369
381
protected List<List<Object > > getTestParams () {
370
382
return [
Original file line number Diff line number Diff line change @@ -36,12 +36,16 @@ class GlassFishSmokeTest extends AppServerTest {
36
36
37
37
@Override
38
38
protected String getSpanName (String path ) {
39
- return path
39
+ switch (path) {
40
+ case " /this-is-definitely-not-there-but-there-should-be-a-trace-nevertheless" :
41
+ return " /*"
42
+ }
43
+ return super . getSpanName(path)
40
44
}
41
45
42
46
@Override
43
47
boolean testRequestWebInfWebXml () {
44
48
false
45
49
}
46
50
47
- }
51
+ }
Original file line number Diff line number Diff line change @@ -18,18 +18,4 @@ class JettySmokeTest extends AppServerTest {
18
18
protected String getTargetImage (String jdk , String serverVersion ) {
19
19
" hypertrace/java-agent-test-containers:jetty-${ serverVersion} -jdk$jdk -20210226.602156580"
20
20
}
21
-
22
- def getJettySpanName () {
23
- " HandlerWrapper.handle"
24
- }
25
-
26
- @Override
27
- protected String getSpanName (String path ) {
28
- switch (path) {
29
- case " /app/WEB-INF/web.xml" :
30
- case " /this-is-definitely-not-there-but-there-should-be-a-trace-nevertheless" :
31
- return getJettySpanName()
32
- }
33
- return path
34
- }
35
21
}
Original file line number Diff line number Diff line change @@ -29,13 +29,10 @@ class LibertySmokeTest extends AppServerTest {
29
29
@Override
30
30
protected String getSpanName (String path ) {
31
31
switch (path) {
32
- case " /app/greeting" :
33
- case " /app/headers" :
34
- case " /app/exception" :
35
- case " /app/asyncgreeting" :
36
- case " /app/echo" :
37
- return path
32
+ case " /app/hello.txt" :
33
+ case " /app/file-that-does-not-exist" :
34
+ return " HTTP GET"
38
35
}
39
- return ' HTTP GET '
36
+ return super . getSpanName(path)
40
37
}
41
38
}
Original file line number Diff line number Diff line change @@ -42,7 +42,7 @@ abstract class SmokeTest extends Specification {
42
42
private Backend backend = Backend . getInstance()
43
43
44
44
@Shared
45
- // protected String agentPath = "/Users/ploffay/projects/hypertrace/javaagent/javaagent/build/libs/hypertrace-agent-0.11.1 -SNAPSHOT-all.jar"// System.getProperty("smoketest.javaagent.path")
45
+ // protected String agentPath = "/Users/ploffay/projects/hypertrace/javaagent/javaagent/build/libs/hypertrace-agent-0.11.2 -SNAPSHOT-all.jar"// System.getProperty("smoketest.javaagent.path")
46
46
protected String agentPath = System . getProperty(" smoketest.javaagent.path" )
47
47
48
48
@Shared
Original file line number Diff line number Diff line change @@ -20,14 +20,4 @@ class TomcatSmokeTest extends AppServerTest {
20
20
protected String getTargetImage (String jdk , String serverVersion ) {
21
21
" hypertrace/java-agent-test-containers:tomcat-${ serverVersion} -jdk$jdk -20210226.602156580"
22
22
}
23
-
24
- @Override
25
- protected String getSpanName (String path ) {
26
- switch (path) {
27
- case " /app/WEB-INF/web.xml" :
28
- case " /this-is-definitely-not-there-but-there-should-be-a-trace-nevertheless" :
29
- return " CoyoteAdapter.service"
30
- }
31
- return path
32
- }
33
23
}
Original file line number Diff line number Diff line change @@ -33,9 +33,9 @@ class TomeeSmokeTest extends AppServerTest {
33
33
@Override
34
34
protected String getSpanName (String path ) {
35
35
switch (path) {
36
- case " /app/WEB-INF/web.xml " :
37
- return " CoyoteAdapter.service "
36
+ case " /this-is-definitely-not-there-but-there-should-be-a-trace-nevertheless " :
37
+ return " /* "
38
38
}
39
- return path
39
+ return super . getSpanName( path)
40
40
}
41
41
}
Original file line number Diff line number Diff line change @@ -21,16 +21,6 @@ class WildflySmokeTest extends AppServerTest {
21
21
" hypertrace/java-agent-test-containers:wildfly-${ serverVersion} -jdk$jdk -20210226.602156580"
22
22
}
23
23
24
- @Override
25
- protected String getSpanName (String path ) {
26
- switch (path) {
27
- case " /app/WEB-INF/web.xml" :
28
- case " /this-is-definitely-not-there-but-there-should-be-a-trace-nevertheless" :
29
- return " DisallowedMethodsHandler.handleRequest"
30
- }
31
- return path
32
- }
33
-
34
24
// TODO These re ignored in the superclass for Wildfly
35
25
// @Ignore
36
26
// @Unroll
You can’t perform that action at this time.
0 commit comments