Skip to content

Commit 635e012

Browse files
authored
Bump to OTEL 1.0.0 (#284)
* Bump to OTEL 1.0.0 Signed-off-by: Pavol Loffay <p.loffay@gmail.com> * Fix Signed-off-by: Pavol Loffay <p.loffay@gmail.com> * Fix smoke Signed-off-by: Pavol Loffay <p.loffay@gmail.com> * Revert Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
1 parent e434cc2 commit 635e012

File tree

14 files changed

+37
-67
lines changed

14 files changed

+37
-67
lines changed

build.gradle.kts

+5-5
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,11 @@ subprojects {
2929
description = "Hypertrace OpenTelemetry Javaagent"
3030

3131
extra.set("versions", mapOf(
32-
"opentelemetry" to "0.17.1",
33-
"opentelemetry_java_agent" to "0.17.0-alpha",
34-
"opentelemetry_java_agent_all" to "0.17.0",
35-
"byte_buddy" to "1.10.18",
36-
"slf4j" to "1.7.30"
32+
"opentelemetry" to "1.0.0",
33+
"opentelemetry_java_agent" to "1.0.0-alpha",
34+
"opentelemetry_java_agent_all" to "1.0.0",
35+
"byte_buddy" to "1.10.18",
36+
"slf4j" to "1.7.30"
3737
))
3838

3939
apply<JavaPlugin>()

instrumentation/servlet/servlet-3.0-no-wrapping/src/main/java/io/opentelemetry/javaagent/instrumentation/hypertrace/servlet/v3_0/nowrapping/Servlet31NoWrappingInstrumentationModule.java

-8
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@
1616

1717
package io.opentelemetry.javaagent.instrumentation.hypertrace.servlet.v3_0.nowrapping;
1818

19-
import static io.opentelemetry.javaagent.tooling.bytebuddy.matcher.ClassLoaderMatcher.hasClassesNamed;
20-
2119
import com.google.auto.service.AutoService;
2220
import io.opentelemetry.javaagent.instrumentation.hypertrace.servlet.v3_0.nowrapping.request.ServletInputStreamInstrumentation;
2321
import io.opentelemetry.javaagent.instrumentation.hypertrace.servlet.v3_0.nowrapping.request.ServletRequestInstrumentation;
@@ -29,7 +27,6 @@
2927
import java.util.HashMap;
3028
import java.util.List;
3129
import java.util.Map;
32-
import net.bytebuddy.matcher.ElementMatcher;
3330
import org.hypertrace.agent.core.instrumentation.SpanAndObjectPair;
3431
import org.hypertrace.agent.core.instrumentation.buffer.BoundedByteArrayOutputStream;
3532
import org.hypertrace.agent.core.instrumentation.buffer.BoundedCharArrayWriter;
@@ -48,11 +45,6 @@ public int getOrder() {
4845
return 1;
4946
}
5047

51-
@Override
52-
public ElementMatcher.Junction<ClassLoader> classLoaderMatcher() {
53-
return hasClassesNamed("javax.servlet.http.HttpServlet");
54-
}
55-
5648
@Override
5749
public List<TypeInstrumentation> typeInstrumentations() {
5850
return Arrays.asList(

instrumentation/servlet/servlet-3.0-no-wrapping/src/test/java/io/opentelemetry/javaagent/instrumentation/hypertrace/servlet/v3_0/nowrapping/Servlet30NoWrappingInstrumentationTest.java

+1
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535
import okhttp3.Request;
3636
import okhttp3.RequestBody;
3737
import okhttp3.Response;
38+
import org.WrappingFilter;
3839
import org.eclipse.jetty.server.Server;
3940
import org.eclipse.jetty.servlet.ServletContextHandler;
4041
import org.hypertrace.agent.core.instrumentation.HypertraceSemanticAttributes;
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package io.opentelemetry.javaagent.instrumentation.hypertrace.servlet.v3_0.nowrapping;
17+
package org;
1818

1919
import java.io.BufferedReader;
2020
import java.io.IOException;
@@ -31,10 +31,6 @@
3131
import javax.servlet.http.HttpServletRequestWrapper;
3232
import javax.servlet.http.HttpServletResponse;
3333
import javax.servlet.http.HttpServletResponseWrapper;
34-
import org.DelegatingBufferedReader;
35-
import org.DelegatingPrintWriter;
36-
import org.DelegatingServletInputStream;
37-
import org.DelegatingServletOutputStream;
3834

3935
public class WrappingFilter implements Filter {
4036

otel-extensions/build.gradle.kts

+1
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ dependencies {
99

1010
compileOnly("io.opentelemetry:opentelemetry-sdk:${versions["opentelemetry"]}")
1111
compileOnly("io.opentelemetry:opentelemetry-sdk-extension-autoconfigure:${versions["opentelemetry"]}-alpha")
12+
implementation("io.opentelemetry:opentelemetry-semconv:${versions["opentelemetry"]}-alpha")
1213
implementation("io.opentelemetry.javaagent:opentelemetry-javaagent-spi:${versions["opentelemetry_java_agent"]}")
1314

1415
implementation("org.slf4j:slf4j-api:${versions["slf4j"]}")

smoke-tests/build.gradle.kts

+2-1
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,14 @@ dependencies{
1515
testImplementation("org.testcontainers:testcontainers:1.15.2")
1616
testImplementation("com.squareup.okhttp3:okhttp:4.9.0")
1717
testImplementation("org.awaitility:awaitility:4.0.3")
18-
testImplementation("io.opentelemetry:opentelemetry-proto:${versions["opentelemetry"]}")
18+
testImplementation("io.opentelemetry:opentelemetry-proto:${versions["opentelemetry"]}-alpha")
1919
testImplementation("io.opentelemetry:opentelemetry-sdk:${versions["opentelemetry"]}")
2020
testImplementation("com.google.protobuf:protobuf-java-util:3.13.0")
2121
testImplementation("org.spockframework:spock-core:1.3-groovy-2.5")
2222
testImplementation("info.solidsoft.spock:spock-global-unroll:0.5.1")
2323
testImplementation("com.fasterxml.jackson.core:jackson-databind:2.11.2")
2424
testImplementation("org.codehaus.groovy:groovy-all:2.5.11")
25+
testImplementation("io.opentelemetry:opentelemetry-semconv:${versions["opentelemetry"]}-alpha")
2526
}
2627

2728
tasks.test {

smoke-tests/src/test/groovy/org/hypertrace/agent/smoketest/AppServerTest.groovy

+13-1
Original file line numberDiff line numberDiff line change
@@ -364,7 +364,19 @@ abstract class AppServerTest extends SmokeTest {
364364
[appServer, jdk] << getTestParams()
365365
}
366366

367-
protected abstract String getSpanName(String path);
367+
protected String getSpanName(String path) {
368+
switch (path) {
369+
case "/app/greeting":
370+
case "/app/headers":
371+
case "/app/exception":
372+
case "/app/asyncgreeting":
373+
return path
374+
case "/app/hello.txt":
375+
case "/app/file-that-does-not-exist":
376+
return "/app/*"
377+
}
378+
return "HTTP GET"
379+
}
368380

369381
protected List<List<Object>> getTestParams() {
370382
return [

smoke-tests/src/test/groovy/org/hypertrace/agent/smoketest/GlassFishSmokeTest.groovy

+6-2
Original file line numberDiff line numberDiff line change
@@ -36,12 +36,16 @@ class GlassFishSmokeTest extends AppServerTest {
3636

3737
@Override
3838
protected String getSpanName(String path) {
39-
return path
39+
switch (path) {
40+
case "/this-is-definitely-not-there-but-there-should-be-a-trace-nevertheless":
41+
return "/*"
42+
}
43+
return super.getSpanName(path)
4044
}
4145

4246
@Override
4347
boolean testRequestWebInfWebXml() {
4448
false
4549
}
4650

47-
}
51+
}

smoke-tests/src/test/groovy/org/hypertrace/agent/smoketest/JettySmokeTest.groovy

-14
Original file line numberDiff line numberDiff line change
@@ -18,18 +18,4 @@ class JettySmokeTest extends AppServerTest {
1818
protected String getTargetImage(String jdk, String serverVersion) {
1919
"hypertrace/java-agent-test-containers:jetty-${serverVersion}-jdk$jdk-20210226.602156580"
2020
}
21-
22-
def getJettySpanName() {
23-
"HandlerWrapper.handle"
24-
}
25-
26-
@Override
27-
protected String getSpanName(String path) {
28-
switch (path) {
29-
case "/app/WEB-INF/web.xml":
30-
case "/this-is-definitely-not-there-but-there-should-be-a-trace-nevertheless":
31-
return getJettySpanName()
32-
}
33-
return path
34-
}
3521
}

smoke-tests/src/test/groovy/org/hypertrace/agent/smoketest/LibertySmokeTest.groovy

+4-7
Original file line numberDiff line numberDiff line change
@@ -29,13 +29,10 @@ class LibertySmokeTest extends AppServerTest {
2929
@Override
3030
protected String getSpanName(String path) {
3131
switch (path) {
32-
case "/app/greeting":
33-
case "/app/headers":
34-
case "/app/exception":
35-
case "/app/asyncgreeting":
36-
case "/app/echo":
37-
return path
32+
case "/app/hello.txt":
33+
case "/app/file-that-does-not-exist":
34+
return "HTTP GET"
3835
}
39-
return 'HTTP GET'
36+
return super.getSpanName(path)
4037
}
4138
}

smoke-tests/src/test/groovy/org/hypertrace/agent/smoketest/SmokeTest.groovy

+1-1
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ abstract class SmokeTest extends Specification {
4242
private Backend backend = Backend.getInstance()
4343

4444
@Shared
45-
// protected String agentPath = "/Users/ploffay/projects/hypertrace/javaagent/javaagent/build/libs/hypertrace-agent-0.11.1-SNAPSHOT-all.jar"// System.getProperty("smoketest.javaagent.path")
45+
// protected String agentPath = "/Users/ploffay/projects/hypertrace/javaagent/javaagent/build/libs/hypertrace-agent-0.11.2-SNAPSHOT-all.jar"// System.getProperty("smoketest.javaagent.path")
4646
protected String agentPath = System.getProperty("smoketest.javaagent.path")
4747

4848
@Shared

smoke-tests/src/test/groovy/org/hypertrace/agent/smoketest/TomcatSmokeTest.groovy

-10
Original file line numberDiff line numberDiff line change
@@ -20,14 +20,4 @@ class TomcatSmokeTest extends AppServerTest {
2020
protected String getTargetImage(String jdk, String serverVersion) {
2121
"hypertrace/java-agent-test-containers:tomcat-${serverVersion}-jdk$jdk-20210226.602156580"
2222
}
23-
24-
@Override
25-
protected String getSpanName(String path) {
26-
switch (path) {
27-
case "/app/WEB-INF/web.xml":
28-
case "/this-is-definitely-not-there-but-there-should-be-a-trace-nevertheless":
29-
return "CoyoteAdapter.service"
30-
}
31-
return path
32-
}
3323
}

smoke-tests/src/test/groovy/org/hypertrace/agent/smoketest/TomeeSmokeTest.groovy

+3-3
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,9 @@ class TomeeSmokeTest extends AppServerTest {
3333
@Override
3434
protected String getSpanName(String path) {
3535
switch (path) {
36-
case "/app/WEB-INF/web.xml":
37-
return "CoyoteAdapter.service"
36+
case "/this-is-definitely-not-there-but-there-should-be-a-trace-nevertheless":
37+
return "/*"
3838
}
39-
return path
39+
return super.getSpanName(path)
4040
}
4141
}

smoke-tests/src/test/groovy/org/hypertrace/agent/smoketest/WildflySmokeTest.groovy

-10
Original file line numberDiff line numberDiff line change
@@ -21,16 +21,6 @@ class WildflySmokeTest extends AppServerTest {
2121
"hypertrace/java-agent-test-containers:wildfly-${serverVersion}-jdk$jdk-20210226.602156580"
2222
}
2323

24-
@Override
25-
protected String getSpanName(String path) {
26-
switch (path) {
27-
case "/app/WEB-INF/web.xml":
28-
case "/this-is-definitely-not-there-but-there-should-be-a-trace-nevertheless":
29-
return "DisallowedMethodsHandler.handleRequest"
30-
}
31-
return path
32-
}
33-
3424
// TODO These re ignored in the superclass for Wildfly
3525
// @Ignore
3626
// @Unroll

0 commit comments

Comments
 (0)