Skip to content

Move Cmp function from channel.Address to wire.Address #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ggwpez opened this issue Oct 6, 2021 · 0 comments · Fixed by #350
Closed

Move Cmp function from channel.Address to wire.Address #234

ggwpez opened this issue Oct 6, 2021 · 0 comments · Fixed by #350
Labels
refactor No logic but only implementation changes.
Milestone
Beautification

Comments

@ggwpez
Copy link
Contributor

ggwpez commented Oct 6, 2021

Location

[wire] address.go and [wallet] address.go

Problem

Interface wallet.Address contains a Cmp(Address) int function which is only used when the wallet.Address is embedded into a wire.Address. wallet.Address.Cmp is itself never called.

Proposal

Move the Cmp function to the wire.Address interface.
@ggwpez ggwpez added this to the Beautification milestone Oct 6, 2021
@ggwpez ggwpez added the refactor No logic but only implementation changes. label Oct 14, 2021
@ggwpez ggwpez self-assigned this Nov 19, 2021
@matthiasgeihs matthiasgeihs pinned this issue Jun 17, 2022
@matthiasgeihs matthiasgeihs mentioned this issue Jun 20, 2022
Merged
@matthiasgeihs matthiasgeihs unpinned this issue Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor No logic but only implementation changes.
Projects
None yet
Milestone
Beautification
Development

Successfully merging a pull request may close this issue.

Separate wire address perun-network/go-perun
1 participant
@ggwpez