Skip to content

Commit 95eeea5

Browse files
committed
feat: add separate events for opening, closing, opened, and closed in accordion
1 parent 59e1069 commit 95eeea5

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

packages/accordion/src/Accordion.svelte

+2-2
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
on:SMUIAccordionPanel:mount={handlePanelMount}
1111
on:SMUIAccordionPanel:unmount={handlePanelUnmount}
1212
on:SMUIAccordionPanel:activate={handlePanelActivate}
13-
on:SMUIAccordionPanel:opened={handlePanelOpened}
13+
on:SMUIAccordionPanel:opening={handlePanelOpening}
1414
{...$$restProps}
1515
>
1616
<slot />
@@ -82,7 +82,7 @@
8282
accessor.setOpen(!accessor.open);
8383
}
8484
85-
function handlePanelOpened(
85+
function handlePanelOpening(
8686
event: CustomEvent<{ accessor: SMUIAccordionPanelAccessor }>
8787
) {
8888
const { accessor } = event.detail;

packages/accordion/src/Panel.svelte

+3-1
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,7 @@
8484
if (content) {
8585
content.style.height = '';
8686
}
87+
dispatch(getElement(), 'SMUIAccordionPanel:opened', { accessor });
8788
},
8889
{ once: true }
8990
);
@@ -95,6 +96,7 @@
9596
if (content) {
9697
content.style.height = '';
9798
}
99+
dispatch(getElement(), 'SMUIAccordionPanel:closed', { accessor });
98100
});
99101
}
100102
@@ -105,7 +107,7 @@
105107
106108
dispatch(
107109
getElement(),
108-
open ? 'SMUIAccordionPanel:opened' : 'SMUIAccordionPanel:closed',
110+
open ? 'SMUIAccordionPanel:opening' : 'SMUIAccordionPanel:closing',
109111
{ accessor }
110112
);
111113
}

packages/accordion/src/ambient.d.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ declare namespace svelte.JSX {
1212
['onSMUIAccordionPanel:activate']?: (
1313
event: CustomEvent<any> & { target: T }
1414
) => any;
15-
['onSMUIAccordionPanel:opened']?: (
15+
['onSMUIAccordionPanel:opening']?: (
1616
event: CustomEvent<any> & { target: T }
1717
) => any;
1818
}

0 commit comments

Comments
 (0)