Skip to content

Cleanup CPP in GHC/Orphans.hs #4529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
fendor opened this issue Mar 25, 2025 · 0 comments · May be fixed by #4567
Open

Cleanup CPP in GHC/Orphans.hs #4529

fendor opened this issue Mar 25, 2025 · 0 comments · May be fixed by #4567
Labels
component: ghcide level: easy The issue is suited for beginners type: enhancement New feature or request

Comments

@fendor
Copy link
Collaborator

fendor commented Mar 25, 2025

The CPP in GHC/Orphans.hs needs to be cleaned up, as it doesn't follow our best practices when it comes to CPP:

  • A CPP #if should span the minimal range possible
  • No nested CPP statements

Especially after #4527 is merged and support for GHC 9.4 series is dropped, we should revisit that module.

GHC 9.4 will likely be dropped after the next release.
@fendor fendor added component: ghcide level: easy The issue is suited for beginners type: enhancement New feature or request labels Mar 25, 2025
@fendor fendor mentioned this issue Mar 26, 2025
Merged
dschrempf added a commit to dschrempf/haskell-language-server that referenced this issue Apr 21, 2025
@dschrempf
Cleanup CPPs, begin deprecation of GHC 9.4
1f5bef2 
Closes haskell#4529.

Also,
- update flake lock
- some girl scout changes while trying to understand some code
This was referenced Apr 21, 2025
Closed
Draft
dschrempf added a commit to dschrempf/haskell-language-server that referenced this issue Apr 23, 2025
@dschrempf
Cleanup CPPs, begin deprecation of GHC 9.4
47cc528 
Closes haskell#4529.

Also,
- update flake lock
- some girl scout changes while trying to understand some code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: ghcide level: easy The issue is suited for beginners type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@fendor