Skip to content

Restore non-redundant func-test completions tests #3843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fendor opened this issue Oct 15, 2023 · 1 comment
Closed

Restore non-redundant func-test completions tests #3843

fendor opened this issue Oct 15, 2023 · 1 comment
Assignees
@fendor
Labels
type: enhancement New feature or request

Comments

@fendor
Copy link
Collaborator

fendor commented Oct 15, 2023 •
edited
Loading

The PR #2838 shows that some of the completions tests from func-test were not redundant but important to ensure correctness. See #2838 (comment) for description.

We should restore these tests and review the testcases in more detail, moving all non-redundant testcases to the ghcide test suite.

The PR that removed them is #3828
@fendor fendor self-assigned this Oct 18, 2023
@fendor
Copy link
Collaborator Author

fendor commented Dec 2, 2023

As the test wasn't deterministic, I don't want to restore it. The behaviour seems well-defined to me.

@fendor fendor closed this as completed Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fendor fendor

Labels
type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fendor