Skip to content

Wingman: Destruct on let-bound term fails #2074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
isovector opened this issue Aug 3, 2021 · 4 comments
Closed

Wingman: Destruct on let-bound term fails #2074

isovector opened this issue Aug 3, 2021 · 4 comments
Labels
component: wingman status: needs info Not actionable, because there's missing information type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..

Comments

@isovector
Copy link
Collaborator

data IntroParams
  = IntroduceAllUnnamed
  | IntroduceOnlyNamed [OccName]
  | IntroduceOnlyUnnamed Int
  deriving stock (Eq, Ord, Show)

intros'
    :: IntroParams
    -> TacticsM ()
intros' params = rule $ \jdg -> do
  let g  = jGoal jdg
  case tacticsSplitFunTy $ unCType g of
    (_, _, [], _) -> cut -- failure $ GoalMismatch "intros" g
    (_, _, args, res) -> do
      ctx <- ask
      let occs = _

trying Desruct params at the hole produces:

      let occs = _
          occs = _
          occs = _

Yikes.

@isovector isovector added type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc.. component: wingman labels Aug 3, 2021
@isovector
Copy link
Collaborator Author

But this feels very similar to something I fixed in #2049, so maybe it's fixed and I'm just running an old version.

@isovector isovector added status: fixed in master status: needs info Not actionable, because there's missing information labels Aug 3, 2021
@isovector
Copy link
Collaborator Author

This is is not fixed in master. I'll investigate.

@isovector isovector removed status: fixed in master status: needs info Not actionable, because there's missing information labels Aug 3, 2021
@isovector
Copy link
Collaborator Author

My test might have been invalidated by #2076. Either way, I'll write a test for this and get it checked in to use the power of CI.

@isovector isovector added status: fixed in master status: needs info Not actionable, because there's missing information labels Aug 21, 2021
@isovector
Copy link
Collaborator Author

This is working in HEAD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: wingman status: needs info Not actionable, because there's missing information type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..
Projects
None yet
Development

No branches or pull requests

1 participant