Skip to content

Make least request available by default (remove GRPC_EXPERIMENTAL_ENABLE_LEAST_REQUEST) #8228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
atollena opened this issue Apr 4, 2025 · 3 comments · May be fixed by #8248
Open

Make least request available by default (remove GRPC_EXPERIMENTAL_ENABLE_LEAST_REQUEST) #8228

atollena opened this issue Apr 4, 2025 · 3 comments · May be fixed by #8248
Assignees
@atollena
Labels
Area: Resolvers/Balancers Includes LB policy & NR APIs, resolver/balancer/picker wrappers, LB policy impls and utilities. P2
Milestone
1.73 Release

Comments

@atollena
Copy link
Collaborator

atollena commented Apr 4, 2025

The gRFC https://github.com/grpc/proposal/blob/master/A48-xds-least-request-lb-policy.md states that the environment variable will be removed when the feature has proven stable. The last substantial changes to least request have been made in #6603 (1.58, Sep 2023).

We have successfully used least request in production for about 1 year, only discovering one minor issue last summer (fixed in #7467, 1.66).

We should consider removing the environment variable and always making least request available.
@atollena atollena changed the title Enable least request by default (GRPC_EXPERIMENTAL_ENABLE_LEAST_REQUEST) Make least request available by default (remove GRPC_EXPERIMENTAL_ENABLE_LEAST_REQUEST) Apr 4, 2025
@atollena atollena added the Area: Resolvers/Balancers Includes LB policy & NR APIs, resolver/balancer/picker wrappers, LB policy impls and utilities. label Apr 4, 2025
@atollena atollena added this to the 1.73 Release milestone Apr 4, 2025
@atollena atollena mentioned this issue Apr 4, 2025
Closed
@arjan-bal
Copy link
Contributor

Based on the comment from Eric assigning to @dfawley to share the result of the discussion.

@davinci26
Copy link

+1 on what @atollena is saying, we are also using it in prod for 6m+ with no issues

atollena added a commit to atollena/grpc-go that referenced this issue Apr 14, 2025
@atollena
xds: Remove temporary environment variable for least request.
5812d40 
Fixes grpc#8228.
atollena added a commit to atollena/grpc-go that referenced this issue Apr 14, 2025
@atollena
xds: Remove temporary environment variable for least request.
c19eba3 
Fixes grpc#8228.
@atollena atollena linked a pull request Apr 14, 2025 that will close this issue
Open
atollena added a commit to atollena/grpc-go that referenced this issue Apr 14, 2025
@atollena
xds: Remove temporary environment variable for least request.
bba5d5c 
Fixes grpc#8228.
@dfawley
Copy link
Member

dfawley commented Apr 16, 2025

#8253 is merged to enable it by default. Let's leave this open to track removing the flag after the 1.73 release.

@dfawley dfawley assigned atollena and unassigned dfawley Apr 16, 2025
@dfawley dfawley added the P2 label Apr 16, 2025
atollena added a commit to atollena/grpc-go that referenced this issue Apr 17, 2025
@atollena
xds: Remove temporary environment variable for least request.
3b1137d 
Fixes grpc#8228.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atollena atollena

Labels
Area: Resolvers/Balancers Includes LB policy & NR APIs, resolver/balancer/picker wrappers, LB policy impls and utilities. P2
Projects
None yet
Milestone
1.73 Release
Development

Successfully merging a pull request may close this issue.

xds: remove temporary environment variable for least request atollena/grpc-go
4 participants
@atollena @dfawley @davinci26 @arjan-bal