Skip to content

The build failed #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
flaky-bot bot opened this issue Jun 17, 2024 · 3 comments · Fixed by #277
Closed

The build failed #275

flaky-bot bot opened this issue Jun 17, 2024 · 3 comments · Fixed by #277
Assignees
Labels
api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented Jun 17, 2024

This test failed!

To configure my behavior, see the Flaky Bot documentation.

If I'm commenting on this issue too often, add the flakybot: quiet label and
I will stop commenting.


commit: a718ce4
buildURL: Build Status, Sponge
status: failed

@flaky-bot flaky-bot bot added flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jun 17, 2024
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. label Jun 17, 2024
@leahecole
Copy link

numpy got a new major around when this was opened https://pypi.org/project/numpy/ - this is likely what's causing this issue

@chalmerlowe
Copy link
Collaborator

@leahecole

I am recommending we pin the version of numpy used with python 3.9 to be less than 2.0.0. See PR #277

There is a potentially unexpected interaction between pandas and numpy here. Depending on the version we use for each, we get different results in terms of pass/fail for the unit tests associated with python 3.9

numpy version pandas version unit-3.9 pass/fail
2.0.0 1.3.0 fail
2.0.0 2.2.2 pass
2.0.0 1.5.3 fail
1.26.4 1.5.3 pass
1.26.4 1.3.0 pass

This appears to be a known incompatibility between how pip resolves the dependency versions for numpy and pandas and the only current fix is to pin versions to something that "works" to avoid allowing pip to resolve into a failing state. (NOTE the linked issue references various versions of numpy and pandas, depending on the combination, inlcuding 3.9 throughout the thread, even though the title references python 3.12)

@leahecole
Copy link

Woof, hopefully we get to a day where they'll play nicely together! in the meantime, for Python 3.9, pinning to less than 2.0.0 feels appropriate. This table is a really helpful visualization, thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants