feat: read_gbq suggests using BigQuery DataFrames with large results
#769
Conversation
product-auto-label
bot
added
the
api: bigquery
|
Edit: Should be fixed by 6ba62d1 |
| @@ -1050,12 +1088,7 @@ def to_gbq( | |||
| ) | |||
|
|
|||
| if api_method == "default": | |||
| # Avoid using parquet if pandas doesn't support lossless conversions to | |||
There was a problem hiding this comment.
per coverage report, this was dead code. Our minimum pandas version is beyond the one where this feature wasn't available.
There was a problem hiding this comment.
thank you this is a helpful comment!
| # Copyright (c) 2024 pandas-gbq Authors All rights reserved. | ||
| # Use of this source code is governed by a BSD-style | ||
| # license that can be found in the LICENSE file. |
There was a problem hiding this comment.
just double checking that this is normal given that we use a difference license header for other Google stuff
There was a problem hiding this comment.
Not normal, but expected. pandas-gbq was originally split off from pandas itself, so we can't use the Google header. It's not 100% Google's copyright since not all contributions were under the CLA.
| @@ -1050,12 +1088,7 @@ def to_gbq( | |||
| ) | |||
|
|
|||
| if api_method == "default": | |||
| # Avoid using parquet if pandas doesn't support lossless conversions to | |||
There was a problem hiding this comment.
thank you this is a helpful comment!
🤖 I have created a release *beep* *boop* --- ## [0.23.0](https://github.com/googleapis/python-bigquery-pandas/compare/v0.22.0...v0.23.0) (2024-05-20) ### Features * `read_gbq` suggests using BigQuery DataFrames with large results ([#769](https://github.com/googleapis/python-bigquery-pandas/issues/769)) ([f937edf](https://github.com/googleapis/python-bigquery-pandas/commit/f937edf5db910257a367b4cc20d865a38b440f75)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes internal issue 340937138
🦕