-
Notifications
You must be signed in to change notification settings - Fork 125
Use google-auth library and requests instead of google-api-client #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
My working hypothesis is we should transition to the But I'm not a maintainer, and I may be missing something - is there a reason we would need to auth separately from that library? |
Yeah |
how much work would be involved to accept this an alternative? iow you try to import oauth2client if that fails you can this package else give up |
I'm happy to help with testing/code review for this addition. |
This sounds great ( or vise-versa, if google-auth , else if oauth2client else give up) |
What's the reason for accepting either library? |
@tswast I see your point. Assuming that we can maintain the existing functionality of Note: Historically, |
ok with changing dependencies. Though nice to have some back-compat. IOW I ok just adding this library, then deprecating the old. |
You guys know this better, but is it worth considering We have built a set of internal functions on this (which we're planning to move into this library). It takes care of a lot of the boilerplate. Is there a compelling reason not to add this as a dependency? |
thats #25; again which am happy to take, assuming things can be built/installed/tested properly. |
Then I think we can also use that library for auth (I believe it wraps I commented here; we can still use json keys with either the |
I'll close this out in favor of eventually moving the API-calling code to google-cloud-python. I've got a separate PR open to move to the new auth library without changing the client libraries. The queries wouldn't be too bad to do with a pure REST call, but the file uploads get a bit hairy, so having a library help with that is ideal. |
The google-auth library provides a Requests interface.
The google-auth library is preferred over the oauth2client library.
Would this project be amenable to a PR to update how the requests to BigQuery are made?
The text was updated successfully, but these errors were encountered: