Parse all date/time types #224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also closes #174 |
|
@tswast no rush; ensuring you saw this though |
|
@tswast gentle ping! |
tswast
approved these changes
Oct 10, 2018
|
Merging despite #226 |
This was referenced Oct 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any date or time value in BQ can be converted to a pandas datetime value. As well as returning dataframes that don't requires as much post-processing, it also reducing the memory footprint of the returned object
I'm not sure whether this will cause any issues around timezones, and whether we need to parse those separately? (though this PR doesn't aim to enable timezone parsing, as long as there's no regression)