Skip to content

Commit 12c9db8

Browse files
authored
fix: Fix name digest for noprefix (#2448)
1 parent 110b80c commit 12c9db8

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

google-cloud-storage/src/main/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig.java

+4-1
Original file line numberDiff line numberDiff line change
@@ -612,7 +612,10 @@ public NoPrefix(SecureRandom rand) {
612612
}
613613

614614
@Override
615-
protected String fmtFields(String randomKey, String nameDigest, String partRange) {
615+
protected String fmtFields(String randomKey, String ultimateObjectName, String partRange) {
616+
HashCode hashCode =
617+
OBJECT_NAME_HASH_FUNCTION.hashString(ultimateObjectName, StandardCharsets.UTF_8);
618+
String nameDigest = B64.encodeToString(hashCode.asBytes());
616619
return randomKey
617620
+ FIELD_SEPARATOR
618621
// todo: do we want to

google-cloud-storage/src/test/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfigTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ public void partNameStrategy_objectNamePrefix() throws Exception {
8484
// name digest
8585
() -> assertField(fmt, 1).hasLength(22),
8686
() -> assertField(fmt, 2).isEqualTo("0001-0096.part"),
87-
() -> assertThat(fmt).startsWith("a/b/obj/"));
87+
() -> assertThat(fmt).startsWith("a/b/obj"));
8888
}
8989

9090
private static StringSubject assertField(String fmt, int idx) {

0 commit comments

Comments
 (0)