Skip to content

Commit a5eaf9f

Browse files
johejoldez
andauthored
govet: add directive and slog passes (#4028)
Co-authored-by: Fernandez Ludovic <ldez@users.noreply.github.com>
1 parent 2741ab2 commit a5eaf9f

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

.golangci.reference.yml

+5
Original file line numberDiff line numberDiff line change
@@ -1063,6 +1063,7 @@ linters-settings:
10631063
- copylocks
10641064
- deepequalerrors
10651065
- defers
1066+
- directive
10661067
- errorsas
10671068
- fieldalignment
10681069
- findcall
@@ -1078,6 +1079,7 @@ linters-settings:
10781079
- shadow
10791080
- shift
10801081
- sigchanyzer
1082+
- slog
10811083
- sortslice
10821084
- stdmethods
10831085
- stringintconv
@@ -1107,6 +1109,8 @@ linters-settings:
11071109
- composites
11081110
- copylocks
11091111
- deepequalerrors
1112+
- defers
1113+
- directive
11101114
- errorsas
11111115
- fieldalignment
11121116
- findcall
@@ -1122,6 +1126,7 @@ linters-settings:
11221126
- shadow
11231127
- shift
11241128
- sigchanyzer
1129+
- slog
11251130
- sortslice
11261131
- stdmethods
11271132
- stringintconv

pkg/golinters/govet.go

+7-1
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ import (
1515
_ "golang.org/x/tools/go/analysis/passes/ctrlflow" // unused, internal analyzer
1616
"golang.org/x/tools/go/analysis/passes/deepequalerrors"
1717
"golang.org/x/tools/go/analysis/passes/defers"
18+
"golang.org/x/tools/go/analysis/passes/directive"
1819
"golang.org/x/tools/go/analysis/passes/errorsas"
1920
"golang.org/x/tools/go/analysis/passes/fieldalignment"
2021
"golang.org/x/tools/go/analysis/passes/findcall"
@@ -32,6 +33,7 @@ import (
3233
"golang.org/x/tools/go/analysis/passes/shadow"
3334
"golang.org/x/tools/go/analysis/passes/shift"
3435
"golang.org/x/tools/go/analysis/passes/sigchanyzer"
36+
"golang.org/x/tools/go/analysis/passes/slog"
3537
"golang.org/x/tools/go/analysis/passes/sortslice"
3638
"golang.org/x/tools/go/analysis/passes/stdmethods"
3739
"golang.org/x/tools/go/analysis/passes/stringintconv"
@@ -62,6 +64,7 @@ var (
6264
copylock.Analyzer,
6365
deepequalerrors.Analyzer,
6466
defers.Analyzer,
67+
directive.Analyzer,
6568
errorsas.Analyzer,
6669
fieldalignment.Analyzer,
6770
findcall.Analyzer,
@@ -77,6 +80,7 @@ var (
7780
shadow.Analyzer,
7881
shift.Analyzer,
7982
sigchanyzer.Analyzer,
83+
slog.Analyzer,
8084
sortslice.Analyzer,
8185
stdmethods.Analyzer,
8286
stringintconv.Analyzer,
@@ -91,7 +95,7 @@ var (
9195
unusedwrite.Analyzer,
9296
}
9397

94-
// https://github.com/golang/go/blob/9f834a559c9ed6cdf883e29b36e21e5f956df74f/src/cmd/vet/main.go#L46-L76
98+
// https://github.com/golang/go/blob/c19c4c566c63818dfd059b352e52c4710eecf14d/src/cmd/vet/main.go#L47-L78
9599
defaultAnalyzers = []*analysis.Analyzer{
96100
asmdecl.Analyzer,
97101
assign.Analyzer,
@@ -101,6 +105,7 @@ var (
101105
cgocall.Analyzer,
102106
composite.Analyzer,
103107
copylock.Analyzer,
108+
directive.Analyzer,
104109
errorsas.Analyzer,
105110
framepointer.Analyzer,
106111
httpresponse.Analyzer,
@@ -111,6 +116,7 @@ var (
111116
printf.Analyzer,
112117
shift.Analyzer,
113118
sigchanyzer.Analyzer,
119+
slog.Analyzer,
114120
stdmethods.Analyzer,
115121
stringintconv.Analyzer,
116122
structtag.Analyzer,

0 commit comments

Comments
 (0)