Skip to content

net: ensure ipv6 endpoints are tried first #54930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

edevil
Copy link

@edevil edevil commented Sep 7, 2022

When connecting to an endpoint that resolves to ipv4 and ipv6 addresses, ensure that ipv6 addresses are tried first, as per happy eyeballs RFC.

Currently whether ipv4 or ipv6 addresses are tried first depends on the DNS resolution speed. If the A resolution returned first, it would be first in the address list, and partition() uses the label of the first result to build the primaries category.

Fixes #54928

When connecting to an endpoint that resolves to ipv4 and ipv6
addresses, ensure that ipv6 addresses are tried first, as per
happy eyeballs RFC.

Currently whether ipv4 or ipv6 addresses are tried first depends on
the dns resolution speed. If the A resolution returned first, it
would be first in the address list, and partition() uses the label
of the first result to build the primaries category.

Fixes golang#54928
@gopherbot
Copy link
Contributor

This PR (HEAD: 1931a3f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/429075 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/429075.
After addressing review feedback, remember to publish your drafts!

@edevil
Copy link
Author

edevil commented Sep 9, 2022

Unsure if this is the correct path.

@edevil edevil closed this Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

net: ipv4 chosen first when both ipv4 and ipv6 are available
2 participants