Skip to content

Commit c5e205e

Browse files
randall77gopherbot
authored andcommitted
internal/runtime/maps: re-enable some tests
Re-enable tests for stack-allocated maps and fast map accessors. Those are implemented now. Update #54766 Change-Id: I8c019702bd9fb077b2fe3f7c78e8e9e10d2263a6 Reviewed-on: https://go-review.googlesource.com/c/go/+/642376 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Keith Randall <khr@google.com> Reviewed-by: Michael Pratt <mpratt@google.com> Auto-Submit: Keith Randall <khr@golang.org>
1 parent befc436 commit c5e205e

File tree

3 files changed

+0
-10
lines changed

3 files changed

+0
-10
lines changed

src/internal/runtime/maps/map_swiss_test.go

-1
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@ func TestTableGroupCount(t *testing.T) {
5050
var testCases = []struct {
5151
n int // n is the number of map elements
5252
escape mapCase // expected values for escaping map
53-
// TODO(go.dev/issue/54766): implement stack allocated maps
5453
}{
5554
{
5655
n: -(1 << 30),

src/runtime/map_test.go

-4
Original file line numberDiff line numberDiff line change
@@ -674,10 +674,6 @@ func TestIgnoreBogusMapHint(t *testing.T) {
674674
var testNonEscapingMapVariable int = 8
675675

676676
func TestNonEscapingMap(t *testing.T) {
677-
if goexperiment.SwissMap {
678-
t.Skip("TODO(go.dev/issue/54766): implement stack allocated maps")
679-
}
680-
681677
n := testing.AllocsPerRun(1000, func() {
682678
m := map[int]int{}
683679
m[0] = 0

test/codegen/maps.go

-5
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,6 @@
44
// Use of this source code is governed by a BSD-style
55
// license that can be found in the LICENSE file.
66

7-
// TODO(#54766): Temporarily disable for swissmap, which have fast variants
8-
// disabled. This test expects fast variants.
9-
//
10-
//go:build !goexperiment.swissmap
11-
127
package codegen
138

149
// This file contains code generation tests related to the handling of

0 commit comments

Comments
 (0)