Skip to content

Commit 5f1e306

Browse files
cmd/coordinator: add blank line before SlowBot message
Avoids a problem seen on https://golang.org/cl/269799: Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test *exactly* your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.SlowBot builds that ran: linux-ppc64-buildlet linux-ppc64le-buildlet Note that "Slowbot builds" is hidden at the end of the failure message. Also slightly clean up the code: numFail is the length of a slice, and can't be negative. Change-Id: Id9c160dbb7031d75232df54b8662c94b2ce464b6 Reviewed-on: https://go-review.googlesource.com/c/build/+/269919 Trust: Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
1 parent 3a574da commit 5f1e306

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

cmd/coordinator/coordinator.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1519,7 +1519,7 @@ func (ts *trySet) noteBuildComplete(bs *buildStatus) {
15191519
return
15201520
}
15211521

1522-
const failureFooter = "Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test *exactly* your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed."
1522+
const failureFooter = "Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test *exactly* your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.\n"
15231523

15241524
s1 := sha1.New()
15251525
io.WriteString(s1, buildLog)
@@ -1569,14 +1569,15 @@ func (ts *trySet) noteBuildComplete(bs *buildStatus) {
15691569
if numFail == 0 {
15701570
score = 1
15711571
fmt.Fprintf(&buf, "%s are happy.\n", name)
1572-
} else if numFail > 0 {
1572+
} else {
15731573
score = -1
15741574
ts.mu.Lock()
15751575
errMsg := ts.errMsg.String()
15761576
ts.mu.Unlock()
15771577
fmt.Fprintf(&buf, "%d of %d %s failed:\n%s\n"+failureFooter,
15781578
numFail, len(ts.builds), name, errMsg)
15791579
}
1580+
fmt.Fprintln(&buf)
15801581
if len(ts.slowBots) > 0 {
15811582
fmt.Fprintf(&buf, "SlowBot builds that ran:\n")
15821583
for _, c := range ts.slowBots {

0 commit comments

Comments
 (0)