Skip to content

Deploy keys will not be deleted at repo delete #6138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 7 tasks
xoxys opened this issue Feb 20, 2019 · 3 comments
Closed
2 of 7 tasks

Deploy keys will not be deleted at repo delete #6138

xoxys opened this issue Feb 20, 2019 · 3 comments

Comments

@xoxys
Copy link
Contributor

xoxys commented Feb 20, 2019

  • Gitea version (or commit ref): v1.7.1
  • Git version:
  • Operating system: CentOS7
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:

Description

If you add a deploy key to a repository and delete the repo, the deploy key will persist in deploy_key table and reference a repo which does not exist anymore. The key also stays included in authorized_keys and can be result in problems if the key is used for other repositorys but in a different mode (read/write).

@jolheiser
Copy link
Member

I believe this was fixed in #5939
Updating to 1.7.2 should fix this issue.

@xoxys
Copy link
Contributor Author

xoxys commented Feb 20, 2019

@jolheiser thanks, I will upgrade and report back

@xoxys
Copy link
Contributor Author

xoxys commented Feb 21, 2019

Fixed. But I have to clean up my database by my own.

@xoxys xoxys closed this as completed Feb 21, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants