Skip to content

Keep merged PR info in hidden branch #3222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lafriks opened this issue Dec 17, 2017 · 3 comments · Fixed by #3368
Closed

Keep merged PR info in hidden branch #3222

lafriks opened this issue Dec 17, 2017 · 3 comments · Fixed by #3368
Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Milestone
1.4.0

Comments

@lafriks
Copy link
Member

lafriks commented Dec 17, 2017

To make merged PR commit tab more stable and consistent for each PR there should be hidden branch created same as github does it - refs/pull/x/head
@lafriks lafriks added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Dec 17, 2017
@lafriks lafriks added this to the 1.x.x milestone Dec 17, 2017
@lafriks lafriks mentioned this issue Dec 17, 2017
Merged
8 tasks
@lafriks
Copy link
Member Author

lafriks commented Dec 28, 2017

I noticed that we do actually already keep such hidden branch, so it just needs to be reused in merged PR to display diff/commits from it

@lunny
Copy link
Member

lunny commented Dec 28, 2017

@lafriks and should that another PR or will be in #3188 ?

@lafriks
Copy link
Member Author

lafriks commented Dec 28, 2017

@lunny that should be another PR to not make #3188 even larger

@lafriks lafriks mentioned this issue Jan 14, 2018
Merged
@lafriks lafriks modified the milestones: 1.x.x, 1.4.0 Jan 14, 2018
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
1.4.0
Development

Successfully merging a pull request may close this issue.

Change how merged PR commit info are prepared lafriks-fork/gitea
2 participants
@lunny @lafriks