Skip to content

Instance-level secrets #27373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jbgomond opened this issue Oct 1, 2023 · 5 comments · May be fixed by #27725
Open

Instance-level secrets #27373

jbgomond opened this issue Oct 1, 2023 · 5 comments · May be fixed by #27725
Labels
proposal/accepted We have reviewed the proposal and agree that it should be implemented like that/at all. topic/gitea-actions related to the actions of Gitea type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@jbgomond
Copy link
Contributor

jbgomond commented Oct 1, 2023

Feature Description

Hello,

Currently, we have user, organization and repository secrets.
But I'm in a case where the secrets will be the same across all the instance. Today, I have to duplicate all values in all organizations.

Would it be a good idea to have them also at the server level ?
Of course, that would apply also to variables, recently added.

Best regards

Screenshots

No response

@jbgomond jbgomond added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Oct 1, 2023
@lunny
Copy link
Member

lunny commented Oct 1, 2023

What's your use case?

@jbgomond
Copy link
Contributor Author

jbgomond commented Oct 1, 2023

I am trying out the actions to replace our current external pipeline when it becomes stable.
It works fine, but our Gitea server is dedicated for projects owned by the firm, and we are sending the docker images to the same registry that needs a login/password.

Today, with secrets at the organization level being the highest, I need to duplicate the DOCKER_LOGIN and DOCKER_PASSWORD secrets to all of them. And if they change, we need to update more than 50 orgs.

Server level secrets would mean being able to set those common values once, by the server administrator. They could be overwritten by organization, repository or user secrets if needed on a case-by-case basis.

@lunny lunny added the proposal/accepted We have reviewed the proposal and agree that it should be implemented like that/at all. label Oct 1, 2023
@jbgomond
Copy link
Contributor Author

I saw the proposal was accepted, thanks ! I'm willing to work on it if no one has started yet :)

@jbgomond jbgomond linked a pull request Oct 21, 2023 that will close this issue
@jbgomond jbgomond changed the title Server level secrets Instance-level secrets Oct 21, 2023
@lunny lunny added the topic/gitea-actions related to the actions of Gitea label Oct 22, 2023
@puni9869
Copy link
Member

Could you explain this for me once again with a use case, specially the instance is that a gitea cluster instance or single instance. If you have org level secrets you can share among all, saying that I would like to learn more about this problem.

@jbgomond
Copy link
Contributor Author

We have a single instance, with secrets that must be shared across all orgs. These secrets are to access to a docker registry in my case. Today, I have to duplicate these credentials in all orgs. Tomorrow, with the PR, I can set them once at the instance level, so they apply across all orgs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal/accepted We have reviewed the proposal and agree that it should be implemented like that/at all. topic/gitea-actions related to the actions of Gitea type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants