Skip to content

Pull request approvals #2417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lunny opened this issue Aug 29, 2017 · 3 comments
Closed

Pull request approvals #2417

lunny opened this issue Aug 29, 2017 · 3 comments
Labels
issue/duplicate The issue has already been reported.

Comments

@lunny
Copy link
Member

lunny commented Aug 29, 2017

A repository could set every pull request needs at least some approvals before it merged.
@lunny lunny added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Aug 29, 2017
@lunny lunny added this to the 1.x.x milestone Aug 29, 2017
@lunny lunny mentioned this issue Aug 29, 2017
Open
20 tasks
@mmarif4u
Copy link

mmarif4u commented Sep 2, 2017

A very useful feature if implemented.

@bkcsoft bkcsoft changed the title Pull request supports approvals Pull request approvals Sep 10, 2017
@lunny lunny added issue/duplicate The issue has already been reported. and removed type/feature Completely new functionality. Can only be merged if feature freeze is not active. labels Oct 28, 2017
@lunny lunny removed this from the 1.x.x milestone Oct 28, 2017
@lunny
Copy link
Member Author

lunny commented Oct 28, 2017

duplicated with #2794

@lunny lunny closed this as completed Oct 28, 2017
@lunny
Copy link
Member Author

lunny commented Nov 26, 2018

@AragurDEV right and we opened another one see #5251 and there is already a PR #5350 to fix that.

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue/duplicate The issue has already been reported.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lunny @mmarif4u