Skip to content

Release page show all tags only if needed - else filter by keyword #20073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
6543 opened this issue Jun 21, 2022 · 0 comments
Open

Release page show all tags only if needed - else filter by keyword #20073

6543 opened this issue Jun 21, 2022 · 0 comments
Labels
type/enhancement An improvement of existing functionality

Comments

@6543
Copy link
Member

6543 commented Jun 21, 2022

at the moment we do just return all tags to compare against ... if you have quite a lot this is not a good practice.

we should only return 10 and let backend filter by keyword - and/or only if desired explicit load all

// TODO(20073) tags are used for compare feature witch needs all tags
// filtering is doen at the client side atm
tagListStart, tagListEnd := 0, 0
if isTagList {
tagListStart, tagListEnd = listOptions.GetStartEnd()
}
tags, err := ctx.Repo.GitRepo.GetTags(tagListStart, tagListEnd)

@6543 6543 added the type/bug label Jun 21, 2022
@6543 6543 changed the title a Release page show all tags only if needed - else filter by keyword Jun 21, 2022
@6543 6543 added type/enhancement An improvement of existing functionality and removed type/bug labels Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement An improvement of existing functionality
Projects
None yet
Development

No branches or pull requests

1 participant