Skip to content

Unable to find git note corresponding to the commit errors in log #19819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pboguslawski opened this issue May 27, 2022 · 3 comments · Fixed by #19884
Closed

Unable to find git note corresponding to the commit errors in log #19819

pboguslawski opened this issue May 27, 2022 · 3 comments · Fixed by #19884
Labels
type/bug
Milestone
1.16.9

Comments

@pboguslawski
Copy link
Contributor

Description

Noticed errors like

2022/05/27 15:55:56 ...git/notes_nogogit.go:50:GetNote() [E] Unable to find git note corresponding to the commit "***". Error: object does not exist [id: , rel_path: 58]

in gitea 1.16.3 (built from sources) log.

Fix from similar issue #18616 is already applied in 1.16.3.

Gitea Version

1.16.3

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Build from sources.

Database

MySQL
@lunny
Copy link
Member

lunny commented Jun 4, 2022

So you mean #18616 has been fixed?

@pboguslawski
Copy link
Contributor Author

pboguslawski commented Jun 4, 2022 •
edited
Loading

Yes, it can see fix

https://github.com/go-gitea/gitea/pull/18635/files

is already present in 1.16.3

https://github.com/go-gitea/gitea/blame/v1.16.3/modules/git/notes_nogogit.go#L24

and this error was thrown by 1.16.3 so looks like one more bug.

@lunny lunny added this to the 1.16.9 milestone Jun 4, 2022
@lunny lunny mentioned this issue Jun 4, 2022
Merged
@zeripath
Copy link
Contributor

zeripath commented Jun 4, 2022

This is just a spurious logging line and can be safely ignored. #19884 will finally stop it.

@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
1.16.9
Development

Successfully merging a pull request may close this issue.

Only log non ErrNotExist errors in git.GetNote lunny/gitea
3 participants
@lunny @zeripath @pboguslawski