Skip to content

Commit fbb424c

Browse files
authored
fix 500 when delete orgnization and resolved #486 (#507)
1 parent e8bac94 commit fbb424c

File tree

2 files changed

+11
-8
lines changed

2 files changed

+11
-8
lines changed

models/org.go

+7-6
Original file line numberDiff line numberDiff line change
@@ -206,12 +206,9 @@ func Organizations(page, pageSize int) ([]*User, error) {
206206

207207
// DeleteOrganization completely and permanently deletes everything of organization.
208208
func DeleteOrganization(org *User) (err error) {
209-
if err := DeleteUser(org); err != nil {
210-
return err
211-
}
212-
213209
sess := x.NewSession()
214-
defer sessionRelease(sess)
210+
defer sess.Close()
211+
215212
if err = sess.Begin(); err != nil {
216213
return err
217214
}
@@ -228,7 +225,11 @@ func DeleteOrganization(org *User) (err error) {
228225
return fmt.Errorf("deleteUser: %v", err)
229226
}
230227

231-
return sess.Commit()
228+
if err = sess.Commit(); err != nil {
229+
return err
230+
}
231+
232+
return RewriteAllPublicKeys()
232233
}
233234

234235
// ________ ____ ___

models/user.go

+4-2
Original file line numberDiff line numberDiff line change
@@ -885,8 +885,10 @@ func deleteUser(e *xorm.Session, u *User) error {
885885
}
886886

887887
avatarPath := u.CustomAvatarPath()
888-
if err := os.Remove(avatarPath); err != nil {
889-
return fmt.Errorf("Fail to remove %s: %v", avatarPath, err)
888+
if com.IsExist(avatarPath) {
889+
if err := os.Remove(avatarPath); err != nil {
890+
return fmt.Errorf("Fail to remove %s: %v", avatarPath, err)
891+
}
890892
}
891893

892894
return nil

0 commit comments

Comments
 (0)