Skip to content

Commit e760992

Browse files
authored
Expose resolver via API (#15167)
* Expose resolver via API
1 parent 290cf75 commit e760992

File tree

4 files changed

+8
-3
lines changed

4 files changed

+8
-3
lines changed

integrations/api_pull_review_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ func TestAPIPullReview(t *testing.T) {
6666
var reviewComments []*api.PullReviewComment
6767
DecodeJSON(t, resp, &reviewComments)
6868
assert.Len(t, reviewComments, 1)
69-
assert.EqualValues(t, "Ghost", reviewComments[0].Reviewer.UserName)
69+
assert.EqualValues(t, "Ghost", reviewComments[0].Poster.UserName)
7070
assert.EqualValues(t, "a review from a deleted user", reviewComments[0].Body)
7171
assert.EqualValues(t, comment.ID, reviewComments[0].ID)
7272
assert.EqualValues(t, comment.UpdatedUnix, reviewComments[0].Updated.Unix())

modules/convert/pull_review.go

+2-1
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,8 @@ func ToPullReviewCommentList(review *models.Review, doer *models.User) ([]*api.P
8686
apiComment := &api.PullReviewComment{
8787
ID: comment.ID,
8888
Body: comment.Content,
89-
Reviewer: ToUser(comment.Poster, doer),
89+
Poster: ToUser(comment.Poster, doer),
90+
Resolver: ToUser(comment.ResolveDoer, doer),
9091
ReviewID: review.ID,
9192
Created: comment.CreatedUnix.AsTime(),
9293
Updated: comment.UpdatedUnix.AsTime(),

modules/structs/pull_review.go

+2-1
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,8 @@ type PullReview struct {
4949
type PullReviewComment struct {
5050
ID int64 `json:"id"`
5151
Body string `json:"body"`
52-
Reviewer *User `json:"user"`
52+
Poster *User `json:"user"`
53+
Resolver *User `json:"resolver"`
5354
ReviewID int64 `json:"pull_request_review_id"`
5455

5556
// swagger:strfmt date-time

templates/swagger/v1_json.tmpl

+3
Original file line numberDiff line numberDiff line change
@@ -15460,6 +15460,9 @@
1546015460
"type": "string",
1546115461
"x-go-name": "HTMLPullURL"
1546215462
},
15463+
"resolver": {
15464+
"$ref": "#/definitions/User"
15465+
},
1546315466
"updated_at": {
1546415467
"type": "string",
1546515468
"format": "date-time",

0 commit comments

Comments
 (0)