Don't select join table's columns (#19660)

lunny · web-flow · commit e435283c0ffe · 2022-05-09T23:19:16.000+08:00
* Don't select join table

* Add comment
diff --git a/models/action.go b/models/action.go
@@ -340,7 +340,9 @@ func GetFeeds(ctx context.Context, opts GetFeedsOptions) (ActionList, error) {
 	}
 
 	e := db.GetEngine(ctx)
-	sess := e.Where(cond).Join("INNER", "repository", "`repository`.id = `action`.repo_id")
+	sess := e.Where(cond).
+		Select("`action`.*"). // this line will avoid select other joined table's columns
+		Join("INNER", "repository", "`repository`.id = `action`.repo_id")
 
 	opts.SetDefaultValues()
 	sess = db.SetSessionPagination(sess, &opts)

Original file line number	Diff line number	Diff line change
`@@ -340,7 +340,9 @@ func GetFeeds(ctx context.Context, opts GetFeedsOptions) (ActionList, error) {`
`340`	`340`	`}`
`341`	`341`
`342`	`342`	`e := db.GetEngine(ctx)`
`343`		- sess := e.Where(cond).Join("INNER", "repository", "`repository`.id = `action`.repo_id")
	`343`	`+ sess := e.Where(cond).`
	`344`	+ Select("`action`.*"). // this line will avoid select other joined table's columns
	`345`	+ Join("INNER", "repository", "`repository`.id = `action`.repo_id")
`344`	`346`
`345`	`347`	`opts.SetDefaultValues()`
`346`	`348`	`sess = db.SetSessionPagination(sess, &opts)`