Skip to content

Commit dac7728

Browse files
authored
Issue fixes for RSS feed improvements (#28380)
Follow-up for #28368 - Just replace button with an a-element with the button class - Remove useless link-action class from template/org/home.tmpl
1 parent bfacb5c commit dac7728

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

templates/org/home.tmpl

+2-2
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,9 @@
2121
</div>
2222
<div class="right menu">
2323
{{if .EnableFeed}}
24-
<button class="link-action ui basic label button gt-mr-0" data-tooltip-content="{{ctx.Locale.Tr "rss_feed"}}" data-url="{{$.Org.HomeLink}}.rss">
24+
<a class="ui basic label button gt-mr-0" href="{{$.Org.HomeLink}}.rss" data-tooltip-content="{{ctx.Locale.Tr "rss_feed"}}">
2525
{{svg "octicon-rss" 24}}
26-
</button>
26+
</a>
2727
{{end}}
2828
<button class="link-action ui basic button gt-mr-0" data-url="{{.Org.HomeLink}}?action={{if $.IsFollowing}}unfollow{{else}}follow{{end}}">
2929
{{if $.IsFollowing}}

templates/repo/header.tmpl

+2-2
Original file line numberDiff line numberDiff line change
@@ -54,9 +54,9 @@
5454
{{end}}
5555
{{if $.EnableFeed}}
5656
{{/* An extra div-element is not necessary here, as this button does not secretly contain two buttons. */}}
57-
<button class="ui compact small basic button" data-url="{{$.RepoLink}}.rss" data-tooltip-content="{{ctx.Locale.Tr "rss_feed"}}">
57+
<a class="ui compact small basic button" href="{{$.RepoLink}}.rss" data-tooltip-content="{{ctx.Locale.Tr "rss_feed"}}">
5858
{{svg "octicon-rss" 16}}
59-
</button>
59+
</a>
6060
{{end}}
6161
<form method="post" action="{{$.RepoLink}}/action/{{if $.IsWatchingRepo}}un{{end}}watch?redirect_to={{$.Link}}">
6262
{{$.CsrfTokenHtml}}

0 commit comments

Comments
 (0)