Skip to content

Commit cc249d9

Browse files
committed
Remove unnecessary goroutine
1 parent b3ef6a6 commit cc249d9

File tree

1 file changed

+12
-14
lines changed

1 file changed

+12
-14
lines changed

services/pull/check.go

+12-14
Original file line numberDiff line numberDiff line change
@@ -28,21 +28,19 @@ var prQueue queue.UniqueQueue
2828

2929
// AddToTaskQueue adds itself to pull request test task queue.
3030
func AddToTaskQueue(pr *models.PullRequest) {
31-
go func() {
32-
err := prQueue.PushFunc(strconv.FormatInt(pr.ID, 10), func() error {
33-
pr.Status = models.PullRequestStatusChecking
34-
err := pr.UpdateColsIfNotMerged("status")
35-
if err != nil {
36-
log.Error("AddToTaskQueue.UpdateCols[%d].(add to queue): %v", pr.ID, err)
37-
} else {
38-
log.Trace("Adding PR ID: %d to the test pull requests queue", pr.ID)
39-
}
40-
return err
41-
})
42-
if err != nil && err != queue.ErrAlreadyInQueue {
43-
log.Error("Error adding prID %d to the test pull requests queue: %v", pr.ID, err)
31+
err := prQueue.PushFunc(strconv.FormatInt(pr.ID, 10), func() error {
32+
pr.Status = models.PullRequestStatusChecking
33+
err := pr.UpdateColsIfNotMerged("status")
34+
if err != nil {
35+
log.Error("AddToTaskQueue.UpdateCols[%d].(add to queue): %v", pr.ID, err)
36+
} else {
37+
log.Trace("Adding PR ID: %d to the test pull requests queue", pr.ID)
4438
}
45-
}()
39+
return err
40+
})
41+
if err != nil && err != queue.ErrAlreadyInQueue {
42+
log.Error("Error adding prID %d to the test pull requests queue: %v", pr.ID, err)
43+
}
4644
}
4745

4846
// checkAndUpdateStatus checks if pull request is possible to leaving checking status,

0 commit comments

Comments
 (0)