Skip to content

Commit a4cb1a6

Browse files
committed
Use native inputs in whitespace dropdown
1 parent c4742fb commit a4cb1a6

File tree

2 files changed

+11
-8
lines changed

2 files changed

+11
-8
lines changed

templates/repo/diff/whitespace_dropdown.tmpl

+8-8
Original file line numberDiff line numberDiff line change
@@ -3,20 +3,20 @@
33
{{svg "octicon-triangle-down" 14 "dropdown icon"}}
44
<div class="menu">
55
<a class="item" href="?style={{if .IsSplitStyle}}split{{else}}unified{{end}}&whitespace=show-all">
6-
<i class="circle {{if eq .WhitespaceBehavior "show-all"}}dot{{else}}outline{{end}} icon"></i>
7-
{{.locale.Tr "repo.diff.whitespace_show_everything"}}
6+
<input id="whitespace-show-all" class="mr-3 pointer-events-none" type="radio"{{if eq .WhitespaceBehavior "show-all"}} checked{{end}}>
7+
<label for="whitespace-show-all" class="pointer-events-none">{{.locale.Tr "repo.diff.whitespace_show_everything"}}</label>
88
</a>
99
<a class="item" href="?style={{if .IsSplitStyle}}split{{else}}unified{{end}}&whitespace=ignore-all">
10-
<i class="circle {{if eq .WhitespaceBehavior "ignore-all"}}dot{{else}}outline{{end}} icon"></i>
11-
{{.locale.Tr "repo.diff.whitespace_ignore_all_whitespace"}}
10+
<input id="whitespace-ignore-all" class="mr-3 pointer-events-none" type="radio"{{if eq .WhitespaceBehavior "ignore-all"}} checked{{end}}>
11+
<label for="whitespace-ignore-all" class="pointer-events-none">{{.locale.Tr "repo.diff.whitespace_ignore_all_whitespace"}}<label>
1212
</a>
1313
<a class="item" href="?style={{if .IsSplitStyle}}split{{else}}unified{{end}}&whitespace=ignore-change">
14-
<i class="circle {{if eq .WhitespaceBehavior "ignore-change"}}dot{{else}}outline{{end}} icon"></i>
15-
{{.locale.Tr "repo.diff.whitespace_ignore_amount_changes"}}
14+
<input id="whitespace-ignore-change" class="mr-3 pen" type="radio"{{if eq .WhitespaceBehavior "ignore-change"}} checked{{end}}>
15+
<label for="whitespace-ignore-change" class="pen">{{.locale.Tr "repo.diff.whitespace_ignore_amount_changes"}}</label>
1616
</a>
1717
<a class="item" href="?style={{if .IsSplitStyle}}split{{else}}unified{{end}}&whitespace=ignore-eol">
18-
<i class="circle {{if eq .WhitespaceBehavior "ignore-eol"}}dot{{else}}outline{{end}} icon"></i>
19-
{{.locale.Tr "repo.diff.whitespace_ignore_at_eol"}}
18+
<input id="whitespace-ignore-eol" class="mr-3 pointer-events-none" type="radio"{{if eq .WhitespaceBehavior "ignore-eol"}} checked{{end}}>
19+
<label for="whitespace-ignore-eol" class="pointer-events-none">{{.locale.Tr "repo.diff.whitespace_ignore_at_eol"}}</label>
2020
</a>
2121
</div>
2222
</div>

web_src/less/helpers.less

+3
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,9 @@
1919
.h-100 { height: 100% !important; }
2020
.br-0 { border-radius: 0 !important; }
2121

22+
/* below class names match tailwind.css */
23+
.pointer-events-none { pointer-events: none !important; }
24+
2225
.mono {
2326
font-family: var(--fonts-monospace) !important;
2427
font-size: .9em !important; /* compensate for monospace fonts being usually slightly larger */

0 commit comments

Comments
 (0)