Skip to content

Commit 674df05

Browse files
authored
Use stderr as fallback if the log file can't be opened (#26074)
If the log file can't be opened, what should it do? panic/exit? ignore logs? fallback to stderr? It seems that "fallback to stderr" is slightly better than others ....
1 parent 4b6764b commit 674df05

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

modules/log/event_writer_file.go

+6-1
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44
package log
55

66
import (
7+
"io"
8+
79
"code.gitea.io/gitea/modules/util/rotatingfilewriter"
810
)
911

@@ -19,7 +21,7 @@ type WriterFileOption struct {
1921

2022
type eventWriterFile struct {
2123
*EventWriterBaseImpl
22-
fileWriter *rotatingfilewriter.RotatingFileWriter
24+
fileWriter io.WriteCloser
2325
}
2426

2527
var _ EventWriter = (*eventWriterFile)(nil)
@@ -37,7 +39,10 @@ func NewEventWriterFile(name string, mode WriterMode) EventWriter {
3739
CompressionLevel: opt.CompressionLevel,
3840
})
3941
if err != nil {
42+
// if the log file can't be opened, what should it do? panic/exit? ignore logs? fallback to stderr?
43+
// it seems that "fallback to stderr" is slightly better than others ....
4044
FallbackErrorf("unable to open log file %q: %v", opt.FileName, err)
45+
w.fileWriter = nopCloser{Writer: LoggerToWriter(FallbackErrorf)}
4146
}
4247
w.OutputWriteCloser = w.fileWriter
4348
return w

0 commit comments

Comments
 (0)