Skip to content

Commit 532da5e

Browse files
authored
Don't show third-party JS errors in production builds (#29303)
So we don't get issues like #29080 and #29273 any more. Only active in [production builds](https://webpack.js.org/guides/production/#specify-the-mode), in non-production the errors will still show.
1 parent 681c3ec commit 532da5e

File tree

1 file changed

+12
-3
lines changed

1 file changed

+12
-3
lines changed

web_src/js/bootstrap.js

+12-3
Original file line numberDiff line numberDiff line change
@@ -29,17 +29,26 @@ export function showGlobalErrorMessage(msg) {
2929
* @param {ErrorEvent} e
3030
*/
3131
function processWindowErrorEvent(e) {
32+
const err = e.error ?? e.reason;
33+
const assetBaseUrl = String(new URL(__webpack_public_path__, window.location.origin));
34+
35+
// error is likely from browser extension or inline script. Do not show these in production builds.
36+
if (!err.stack?.includes(assetBaseUrl) && window.config?.runModeIsProd) return;
37+
38+
let message;
3239
if (e.type === 'unhandledrejection') {
33-
showGlobalErrorMessage(`JavaScript promise rejection: ${e.reason}. Open browser console to see more details.`);
34-
return;
40+
message = `JavaScript promise rejection: ${err.message}.`;
41+
} else {
42+
message = `JavaScript error: ${e.message} (${e.filename} @ ${e.lineno}:${e.colno}).`;
3543
}
44+
3645
if (!e.error && e.lineno === 0 && e.colno === 0 && e.filename === '' && window.navigator.userAgent.includes('FxiOS/')) {
3746
// At the moment, Firefox (iOS) (10x) has an engine bug. See https://github.com/go-gitea/gitea/issues/20240
3847
// If a script inserts a newly created (and content changed) element into DOM, there will be a nonsense error event reporting: Script error: line 0, col 0.
3948
return; // ignore such nonsense error event
4049
}
4150

42-
showGlobalErrorMessage(`JavaScript error: ${e.message} (${e.filename} @ ${e.lineno}:${e.colno}). Open browser console to see more details.`);
51+
showGlobalErrorMessage(`${message} Open browser console to see more details.`);
4352
}
4453

4554
function initGlobalErrorHandler() {

0 commit comments

Comments
 (0)