Enable deprecation error for v1.17.0

Gusted · Gusted · commit 4b92fb2c4b0e · 2022-01-20T14:22:23.000+01:00
Per title
diff --git a/modules/setting/mirror.go b/modules/setting/mirror.go
@@ -32,7 +32,7 @@ func newMirror() {
 	// - please note this was badly named and only disabled the creation of new pull mirrors
 	if Cfg.Section("repository").Key("DISABLE_MIRRORS").MustBool(false) {
 		log.Warn("Deprecated DISABLE_MIRRORS config is used, please change your config and use the options within the [mirror] section")
-		// TODO: enable on v1.17.0: log.Error("Deprecated fallback used, will be removed in v1.18.0")
+		log.Error("Deprecated fallback used, will be removed in v1.18.0")
 		Mirror.DisableNewPull = true
 	}
 	if err := Cfg.Section("mirror").MapTo(&Mirror); err != nil {

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ func newMirror() {`
`32`	`32`	`// - please note this was badly named and only disabled the creation of new pull mirrors`
`33`	`33`	`if Cfg.Section("repository").Key("DISABLE_MIRRORS").MustBool(false) {`
`34`	`34`	`log.Warn("Deprecated DISABLE_MIRRORS config is used, please change your config and use the options within the [mirror] section")`
`35`		`- // TODO: enable on v1.17.0: log.Error("Deprecated fallback used, will be removed in v1.18.0")`
	`35`	`+ log.Error("Deprecated fallback used, will be removed in v1.18.0")`
`36`	`36`	`Mirror.DisableNewPull = true`
`37`	`37`	`}`
`38`	`38`	`if err := Cfg.Section("mirror").MapTo(&Mirror); err != nil {`