Skip to content

Commit 2728f0c

Browse files
authored
Fix migrate release from github (#19510)
* Fix migrate release from github * Fix bug
1 parent 41fcf7b commit 2728f0c

File tree

1 file changed

+12
-9
lines changed

1 file changed

+12
-9
lines changed

services/migrations/gitea_uploader.go

+12-9
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ package migrations
77

88
import (
99
"context"
10+
"errors"
1011
"fmt"
1112
"io"
1213
"os"
@@ -253,7 +254,6 @@ func (g *GiteaLocalUploader) CreateReleases(releases ...*base.Release) error {
253254
LowerTagName: strings.ToLower(release.TagName),
254255
Target: release.TargetCommitish,
255256
Title: release.Name,
256-
Sha1: release.TargetCommitish,
257257
Note: release.Body,
258258
IsDraft: release.Draft,
259259
IsPrerelease: release.Prerelease,
@@ -265,15 +265,18 @@ func (g *GiteaLocalUploader) CreateReleases(releases ...*base.Release) error {
265265
return err
266266
}
267267

268-
// calc NumCommits if no draft
269-
if !release.Draft {
268+
// calc NumCommits if possible
269+
if rel.TagName != "" {
270270
commit, err := g.gitRepo.GetTagCommit(rel.TagName)
271-
if err != nil {
272-
return fmt.Errorf("GetTagCommit[%v]: %v", rel.TagName, err)
273-
}
274-
rel.NumCommits, err = commit.CommitsCount()
275-
if err != nil {
276-
return fmt.Errorf("CommitsCount: %v", err)
271+
if !errors.Is(err, git.ErrNotExist{}) {
272+
if err != nil {
273+
return fmt.Errorf("GetTagCommit[%v]: %v", rel.TagName, err)
274+
}
275+
rel.Sha1 = commit.ID.String()
276+
rel.NumCommits, err = commit.CommitsCount()
277+
if err != nil {
278+
return fmt.Errorf("CommitsCount: %v", err)
279+
}
277280
}
278281
}
279282

0 commit comments

Comments
 (0)