Fix Notify Create Ref Error on tag creation (#8936)

zeripath · sapk · commit 253fdfb7fab5 · 2019-11-13T00:49:40.000+01:00
* Fix Notify Create Ref Error on tag creation

* Just use the provided full ref instead of BranchCommit
diff --git a/modules/notification/webhook/webhook.go b/modules/notification/webhook/webhook.go
@@ -573,9 +573,9 @@ func (m *webhookNotifier) NotifyCreateRef(pusher *models.User, repo *models.Repo
 		return
 	}
 
-	shaSum, err := gitRepo.GetBranchCommitID(refName)
+	shaSum, err := gitRepo.GetRefCommitID(refFullName)
 	if err != nil {
-		log.Error("GetBranchCommitID[%s]: %v", refFullName, err)
+		log.Error("GetRefCommitID[%s]: %v", refFullName, err)
 		return
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -573,9 +573,9 @@ func (m webhookNotifier) NotifyCreateRef(pusher models.User, repo *models.Repo`
`573`	`573`	`return`
`574`	`574`	`}`
`575`	`575`
`576`		`- shaSum, err := gitRepo.GetBranchCommitID(refName)`
	`576`	`+ shaSum, err := gitRepo.GetRefCommitID(refFullName)`
`577`	`577`	`if err != nil {`
`578`		`- log.Error("GetBranchCommitID[%s]: %v", refFullName, err)`
	`578`	`+ log.Error("GetRefCommitID[%s]: %v", refFullName, err)`
`579`	`579`	`return`
`580`	`580`	`}`
`581`	`581`