Skip to content

Commit 21b8ec2

Browse files
authored
Add eslint-plugin-vue-scoped-css (#26720)
Adds [eslint-plugin-vue-scoped-css](https://github.com/future-architect/eslint-plugin-vue-scoped-css) and fixes discovered issues which are: - 1 unused selector - 3 selectors with `.full.height` parent in a `<style scoped>` block so the rule could not find the parent. Move these into the unscoped block instead. They worked before and after.
1 parent 7b05d66 commit 21b8ec2

File tree

4 files changed

+210
-23
lines changed

4 files changed

+210
-23
lines changed

package-lock.json

+188
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+1
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@
6969
"eslint-plugin-sonarjs": "0.20.0",
7070
"eslint-plugin-unicorn": "48.0.1",
7171
"eslint-plugin-vue": "9.17.0",
72+
"eslint-plugin-vue-scoped-css": "2.5.0",
7273
"eslint-plugin-wc": "1.5.0",
7374
"jsdom": "22.1.0",
7475
"markdownlint-cli": "0.35.0",

web_src/js/components/.eslintrc.yaml

+3
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,11 @@
11
plugins:
22
- eslint-plugin-vue
3+
- eslint-plugin-vue-scoped-css
34

45
extends:
56
- ../../../.eslintrc.yaml
67
- plugin:vue/vue3-recommended
8+
- plugin:vue-scoped-css/vue3-recommended
79

810
env:
911
browser: true
@@ -12,3 +14,4 @@ rules:
1214
vue/attributes-order: [0]
1315
vue/html-closing-bracket-spacing: [2, {startTag: never, endTag: never, selfClosingTag: never}]
1416
vue/max-attributes-per-line: [0]
17+
vue-scoped-css/enforce-style-type: [0]

web_src/js/components/RepoActionView.vue

+18-23
Original file line numberDiff line numberDiff line change
@@ -524,11 +524,6 @@ export function initRepositoryActionView() {
524524
overflow-y: auto;
525525
}
526526
527-
.job-group-section .job-group-summary {
528-
margin: 5px 0;
529-
padding: 10px;
530-
}
531-
532527
.job-artifacts-title {
533528
font-size: 18px;
534529
margin-top: 16px;
@@ -674,24 +669,6 @@ export function initRepositoryActionView() {
674669
675670
/* end fomantic dropdown menu overrides */
676671
677-
/* selectors here are intentionally exact to only match fullscreen */
678-
679-
.full.height > .action-view-right {
680-
width: 100%;
681-
height: 100%;
682-
padding: 0;
683-
border-radius: 0;
684-
}
685-
686-
.full.height > .action-view-right > .job-info-header {
687-
border-radius: 0;
688-
}
689-
690-
.full.height > .action-view-right > .job-step-container {
691-
height: calc(100% - 60px);
692-
border-radius: 0;
693-
}
694-
695672
.job-info-header {
696673
display: flex;
697674
justify-content: space-between;
@@ -834,6 +811,24 @@ export function initRepositoryActionView() {
834811
margin-left: 10px;
835812
}
836813
814+
/* selectors here are intentionally exact to only match fullscreen */
815+
816+
.full.height > .action-view-right {
817+
width: 100%;
818+
height: 100%;
819+
padding: 0;
820+
border-radius: 0;
821+
}
822+
823+
.full.height > .action-view-right > .job-info-header {
824+
border-radius: 0;
825+
}
826+
827+
.full.height > .action-view-right > .job-step-container {
828+
height: calc(100% - 60px);
829+
border-radius: 0;
830+
}
831+
837832
/* TODO: group support
838833
839834
.job-log-group {

0 commit comments

Comments
 (0)