Do not call nil handler for a dummy queue (#24880)

wxiaoguang · web-flow · commit 16a766cba10d · 2023-05-23T13:40:55.000+02:00
A dummy queue doesn't really have a handler (see line 211), so the
`safeHandler` can safely drop all items
diff --git a/modules/queue/workerqueue.go b/modules/queue/workerqueue.go
@@ -239,7 +239,10 @@ func NewWorkerPoolQueueBySetting[T any](name string, queueSetting setting.QueueS
 				log.Error("Recovered from panic in queue %q handler: %v\n%s", name, err, log.Stack(2))
 			}
 		}()
-		return w.origHandler(t...)
+		if w.origHandler != nil {
+			return w.origHandler(t...)
+		}
+		return nil
 	}
 
 	return &w, nil

Original file line number	Diff line number	Diff line change
`@@ -239,7 +239,10 @@ func NewWorkerPoolQueueBySetting[T any](name string, queueSetting setting.QueueS`
`239`	`239`	`log.Error("Recovered from panic in queue %q handler: %v\n%s", name, err, log.Stack(2))`
`240`	`240`	`}`
`241`	`241`	`}()`
`242`		`- return w.origHandler(t...)`
	`242`	`+ if w.origHandler != nil {`
	`243`	`+ return w.origHandler(t...)`
	`244`	`+ }`
	`245`	`+ return nil`
`243`	`246`	`}`
`244`	`247`
`245`	`248`	`return &w, nil`