Fix wrong workflow status when rerun a job in an already finished workflow (#26119) (#26124)

GiteaBot · yp05327 · web-flow · commit 08cdc0da3d6a · 2023-07-25T12:22:58.000+02:00
Backport #26119 by @yp05327 Before: ![image](https://github.com/go-gitea/gitea/assets/18380374/fb687592-b117-4cd5-b076-2ca5ca847ea4) After: ![image](https://github.com/go-gitea/gitea/assets/18380374/c9b0683e-e81d-410b-8c35-fbe54327fab4) After workflow finished, if you rerun a single job, the workflow status will become to `Running` which is not correct as no jobs are running in this workflow. Co-authored-by: yp05327 <576951401@qq.com>
diff --git a/models/actions/run_job.go b/models/actions/run_job.go
@@ -143,7 +143,7 @@ func aggregateJobStatus(jobs []*ActionRunJob) Status {
 		if !job.Status.IsDone() {
 			allDone = false
 		}
-		if job.Status != StatusWaiting {
+		if job.Status != StatusWaiting && !job.Status.IsDone() {
 			allWaiting = false
 		}
 		if job.Status == StatusFailure || job.Status == StatusCancelled {

Original file line number	Diff line number	Diff line change
`@@ -143,7 +143,7 @@ func aggregateJobStatus(jobs []*ActionRunJob) Status {`
`143`	`143`	`if !job.Status.IsDone() {`
`144`	`144`	`allDone = false`
`145`	`145`	`}`
`146`		`- if job.Status != StatusWaiting {`
	`146`	`+ if job.Status != StatusWaiting && !job.Status.IsDone() {`
`147`	`147`	`allWaiting = false`
`148`	`148`	`}`
`149`	`149`	`if job.Status == StatusFailure \|\| job.Status == StatusCancelled {`