Please support private Docker registries with a non-default port

[jankeromnes]

Bug description

Today in Gitpod, you can use private Docker images by specifying a GITPOD_IMAGE_AUTH Project-level variable as described in:

https://www.gitpod.io/docs/configure/workspaces/workspace-image#use-a-private-docker-image

Unfortunately, since : was used as a separator, you cannot specify Docker registries with non-default ports, i.e.:

• Specifying registry.example.com works ✅

  • (GITPOD_IMAGE_AUTH="registry.example.com:Zm9vOmJhcg==" is properly recognized 👍)

• Specifying registry.example.com:1337 doesn't work ❌

  • (GITPOD_IMAGE_AUTH="registry.example.com:1337:Zm9vOmJhcg==" is ignored due to the double : 😖)

Steps to reproduce

1. Try to specify a private Docker registry using a non-default port (like registry.example.com:1337)

Workspace affected

No response

Expected behavior

No response

Example repository

No response

Anything else?

The following code ignores any value of GITPOD_IMAGE_AUTH that doesn't have exactly one : character:

gitpod/components/server/src/workspace/workspace-starter.ts

Lines 695 to 699 in 508148b

	(imageAuthValue.value || "")
	.split(",")
	.map((e) => e.trim().split(":"))
	.filter((e) => e.length == 2)
	.forEach((e) => res.set(e[0], e[1]));

Suggestion: Maybe, it could instead split on the last occurrence of a :, and allow 0 or 1 : to be present in the Docker registry hostname ? (Or, maybe it could allow a base64-encoded Docker registry hostname?)

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.