-
Notifications
You must be signed in to change notification settings - Fork 11.6k
server: exit failure if --embedding
is set with an incoherent --ubatch-size
#6263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
--embedding
is started with a wrong --ubatch-size
--embedding
is set with an incoherent --ubatch-size
Yeah I think it's ok to do so.
I think we should only warn the user if n_ctx_train > n_batch (just like in If n_ctx_train < n_batch then we don't care, because users with low RAM may want to use a smaller n_batch. Only when n_tokens > n_batch then we throw an error. |
For
It might be a little confusing to users bc the default value of |
That's the idea of this ticket, user must configure good values for the embedding model. |
That sounds right 👍 , we just need to ensure that the error message properly guides the users to provide the same values for both |
Adding this info in the README under the |
Context
there is no advantage to increase
n_batch
aboven_ubatch
with embeddings models with pooling, because the entire batch must fit in a physical batch (ie.n_ubatch
).n_batch
is always>= n_ubatch
.--threads
and--threads
,--ubatch-size
,--log-disable
#6254 (comment)Proposition
Exit failure if
--embedding
is set and--ubatch-size
!=--batch-size
in theserver
example. Probably also in theretrieval
example in #6193.Aldo probably KV
bert.context_size
must be taken into account.The text was updated successfully, but these errors were encountered: