Skip to content

Commit 19cbf8a

Browse files
committed
fix nits
Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
1 parent 9709e52 commit 19cbf8a

File tree

3 files changed

+7
-9
lines changed

3 files changed

+7
-9
lines changed

docs/spec/v1beta2/buckets.md

+4-4
Original file line numberDiff line numberDiff line change
@@ -440,7 +440,7 @@ data:
440440
##### Workload Identity
441441

442442
If you have [Workload Identity](https://azure.github.io/azure-workload-identity/docs/installation/managed-clusters.html)
443-
set up on your cluster. You need to create an Azure Identity and give it
443+
set up on your cluster, you need to create an Azure Identity and give it
444444
access to Azure Blob Storage.
445445

446446
```shell
@@ -501,7 +501,7 @@ patches:
501501
```
502502

503503
If you have set up Workload Identity correctly and labeled the source-controller
504-
Pod and ServiceAccount, then you don't need to reference a Secret. For more information,
504+
Deployment and ServiceAccount, then you don't need to reference a Secret. For more information,
505505
please see [documentation](https://azure.github.io/azure-workload-identity/docs/quick-start.html).
506506

507507
```yaml
@@ -561,7 +561,7 @@ spec:
561561
selector: ${IDENTITY_NAME}
562562
```
563563

564-
Label the source-controller correctly so that it can match an identity binding:
564+
Label the source-controller Deployment correctly so that it can match an identity binding:
565565

566566
```yaml
567567
apiVersion: apps/v1
@@ -577,7 +577,7 @@ spec:
577577
```
578578

579579
If you have set up aad-pod-identity correctly and labeled the source-controller
580-
Pod, then you don't need to reference a Secret.
580+
Deployment, then you don't need to reference a Secret.
581581

582582
```yaml
583583
apiVersion: source.toolkit.fluxcd.io/v1beta2

docs/spec/v1beta2/helmrepositories.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -276,7 +276,7 @@ patches:
276276
azure.workload.identity/use: "true"
277277
```
278278

279-
Ensure Workload Identity is properly setup on your cluster and the mutating webhook is installed.
279+
Ensure Workload Identity is properly set up on your cluster and the mutating webhook is installed.
280280
Create an identity that has access to ACR. Next, establish
281281
a federated identity between the source-controller ServiceAccount and the
282282
identity. Patch the source-controller Deployment and ServiceAccount as shown in the patch

docs/spec/v1beta2/ocirepositories.md

+2-4
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,6 @@ by setting the `AZURE_CLIENT_ID` environment variable in the source-controller d
172172
If you are running into further issues, please look at the
173173
[troubleshooting guide](https://github.com/Azure/azure-sdk-for-go/blob/main/sdk/azidentity/TROUBLESHOOTING.md#azure-virtual-machine-managed-identity).
174174

175-
176175
##### Workload Identity
177176

178177
When using Workload Identity to enable access to ACR, add the following patch to
@@ -210,7 +209,7 @@ patches:
210209
azure.workload.identity/use: "true"
211210
```
212211

213-
Ensure Workload Identity is properly setup on your cluster and the mutating webhook is installed.
212+
Ensure Workload Identity is properly set up on your cluster and the mutating webhook is installed.
214213
Create an identity that has access to ACR. Next, establish
215214
a federated identity between the source-controller ServiceAccount and the
216215
identity. Patch the source-controller Deployment and ServiceAccount as shown in the patch
@@ -221,7 +220,6 @@ above. Please take a look at this [guide](https://azure.github.io/azure-workload
221220
**Note:** The AAD Pod Identity project will be archived in [September 2023](https://github.com/Azure/aad-pod-identity#-announcement),
222221
and you are advised to use Workload Identity instead.
223222

224-
225223
When using aad-pod-identity to enable access to ACR, add the following patch to
226224
your bootstrap repository, in the `flux-system/kustomization.yaml` file:
227225

@@ -246,7 +244,7 @@ has to be used to give the `source-controller` pod access to the ACR.
246244
To do this, you have to install `aad-pod-identity` on your cluster, create a managed identity
247245
that has access to the container registry (this can also be the Kubelet identity
248246
if it has `AcrPull` role assignment on the ACR), create an `AzureIdentity` and `AzureIdentityBinding`
249-
that describe the managed identity and then label the `source-controller` pods
247+
that describe the managed identity and then label the `source-controller` deployment
250248
with the name of the AzureIdentity as shown in the patch above. Please take a look
251249
at [this guide](https://azure.github.io/aad-pod-identity/docs/) or
252250
[this one](https://docs.microsoft.com/en-us/azure/aks/use-azure-ad-pod-identity)

0 commit comments

Comments
 (0)