simplify setting of humanReadableSize

makkes · hiddeco · web-flow · commit 18c4d4af914e · 2022-04-22T10:23:09.000+02:00
Co-authored-by: Hidde Beydals &lt;hiddeco@users.noreply.github.com&gt;
diff --git a/controllers/helmrepository_controller.go b/controllers/helmrepository_controller.go
@@ -255,12 +255,9 @@ func (r *HelmRepositoryReconciler) notify(oldObj, newObj *sourcev1.HelmRepositor
 			sourcev1.GroupVersion.Group + "/checksum": newObj.Status.Artifact.Checksum,
 		}
 
-		size := newObj.Status.Artifact.Size
-		var humanReadableSize string
-		if size != nil {
+		humanReadableSize := "unknown size"
+		if newObj.Status.Artifact.Size != nil {
 			humanReadableSize = fmt.Sprintf("size %s", units.HumanSize(float64(*size)))
-		} else {
-			humanReadableSize = "unknown size"
 		}
 
 		var oldChecksum string

Original file line number	Diff line number	Diff line change
`@@ -255,12 +255,9 @@ func (r HelmRepositoryReconciler) notify(oldObj, newObj sourcev1.HelmRepositor`
`255`	`255`	`sourcev1.GroupVersion.Group + "/checksum": newObj.Status.Artifact.Checksum,`
`256`	`256`	`}`
`257`	`257`
`258`		`- size := newObj.Status.Artifact.Size`
`259`		`- var humanReadableSize string`
`260`		`- if size != nil {`
	`258`	`+ humanReadableSize := "unknown size"`
	`259`	`+ if newObj.Status.Artifact.Size != nil {`
`261`	`260`	`humanReadableSize = fmt.Sprintf("size %s", units.HumanSize(float64(*size)))`
`262`		`- } else {`
`263`		`- humanReadableSize = "unknown size"`
`264`	`261`	`}`
`265`	`262`
`266`	`263`	`var oldChecksum string`