Fix HelmChart local dependency resolution for name-based path

Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>

Author: matheuscscp

internal/helm/chart/dependency_manager.go

@@ -296,6 +296,9 @@ func (dm *DependencyManager) resolveRepository(url string) (repo repository.Down
 // It does not allow the dependency's path to be outside the scope of
 // LocalReference.WorkDir.
 func (dm *DependencyManager) secureLocalChartPath(ref LocalReference, dep *helmchart.Dependency) (string, error) {
+	if dep.Repository == "" {
+		return securejoin.SecureJoin(ref.WorkDir, filepath.Join(ref.Path, "charts", dep.Name))
+	}
 	localUrl, err := url.Parse(dep.Repository)
 	if err != nil {
 		return "", fmt.Errorf("failed to parse alleged local chart reference: %w", err)

internal/helm/chart/dependency_manager_test.go

@@ -844,6 +844,15 @@ func TestDependencyManager_secureLocalChartPath(t *testing.T) {
 			},
 			wantErr: "not a local chart reference",
 		},
+		{
+			name: "local dependency with empty repository",
+			dep: &helmchart.Dependency{
+				Name: "some-subchart",
+			},
+			baseDir: "/tmp/workdir",
+			path:    "/chart",
+			want:    "/tmp/workdir/chart/charts/some-subchart",
+		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {