Skip to content

Commit 93696f4

Browse files
authored
Rollup merge of rust-lang#72938 - lzutao:stabilize_option_zip, r=dtolnay
Stabilize Option::zip This PR stabilizes the following API: ```rust impl<T> Option<T> { pub fn zip<U>(self, other: Option<U>) -> Option<(T, U)>; } ``` This API has real world usage as seen in <https://grep.app/search?q=-%3E%20Option%3C%5C%28T%2C%5Cs%3FU%5C%29%3E&regexp=true&filter[lang][0]=Rust>. The `zip_with` method is left unstably as this API is kinda niche and it hasn't received much usage in Rust repositories on GitHub. cc rust-lang#70086
2 parents 9217ef2 + 994a839 commit 93696f4

File tree

1 file changed

+5
-10
lines changed

1 file changed

+5
-10
lines changed

clippy_lints/src/checked_conversions.rs

+5-10
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ fn double_check<'a>(cx: &LateContext<'_, '_>, left: &'a Expr<'_>, right: &'a Exp
8888
let upper = check_upper_bound(l);
8989
let lower = check_lower_bound(r);
9090

91-
transpose(upper, lower).and_then(|(l, r)| l.combine(r, cx))
91+
upper.zip(lower).and_then(|(l, r)| l.combine(r, cx))
9292
};
9393

9494
upper_lower(left, right).or_else(|| upper_lower(right, left))
@@ -131,7 +131,10 @@ impl<'a> Conversion<'a> {
131131

132132
/// Checks if the to-type is the same (if there is a type constraint)
133133
fn has_compatible_to_type(&self, other: &Self) -> bool {
134-
transpose(self.to_type.as_ref(), other.to_type.as_ref()).map_or(true, |(l, r)| l == r)
134+
match (self.to_type, other.to_type) {
135+
(Some(l), Some(r)) => l == r,
136+
_ => true,
137+
}
135138
}
136139

137140
/// Try to construct a new conversion if the conversion type is valid
@@ -322,14 +325,6 @@ fn int_ty_to_sym<'tcx>(path: &QPath<'_>) -> Option<&'tcx str> {
322325
}
323326
}
324327

325-
/// (Option<T>, Option<U>) -> Option<(T, U)>
326-
fn transpose<T, U>(lhs: Option<T>, rhs: Option<U>) -> Option<(T, U)> {
327-
match (lhs, rhs) {
328-
(Some(l), Some(r)) => Some((l, r)),
329-
_ => None,
330-
}
331-
}
332-
333328
/// Will return the expressions as if they were expr1 <= expr2
334329
fn normalize_le_ge<'a>(op: &BinOp, left: &'a Expr<'a>, right: &'a Expr<'a>) -> Option<(&'a Expr<'a>, &'a Expr<'a>)> {
335330
match op.node {

0 commit comments

Comments
 (0)