Fixed recursive call of assertion errors which led to a huge delay when a test failed - Fixes #278

Author: ppmathis

lib/assert/error.js

@@ -75,7 +75,12 @@ function errorDiff(err, type) {
   }).join('');
 }
 
-require('assert').AssertionError.prototype.toString = function () {
+/*
+ Do not override .toString() when this.stack is used,
+ otherwise this will end in an endless recursive call...
+ See issue https://github.com/cloudhead/vows/issues/278#issuecomment-22837493
+*/
+require('assert').AssertionError.prototype.toStringEx = function () {
     var that = this,
         source;
 

lib/vows.js

@@ -136,7 +136,7 @@ function addVow(vow) {
             output('honored');
         } catch (e) {
             if (e.name && e.name.match(/AssertionError/)) {
-                output('broken', e.toString().replace(/\`/g, '`'));
+                output('broken', e.toStringEx().replace(/\`/g, '`'));
             } else {
                 output('errored', e.stack || e.message || e);
             }